From 604879d1a35b537f33c592c73e16e2feb7952811 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mike=20F=C3=A4hrmann?= <mike_faehrmann@web.de>
Date: Mon, 28 Oct 2024 14:44:15 +0100
Subject: [PATCH] [reddit] simplify

- use 'self.groups' to access matched values
- use 'str.format()' to build URL
---
 gallery_dl/extractor/reddit.py | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/gallery_dl/extractor/reddit.py b/gallery_dl/extractor/reddit.py
index 8b6df063..89eafc8a 100644
--- a/gallery_dl/extractor/reddit.py
+++ b/gallery_dl/extractor/reddit.py
@@ -344,15 +344,12 @@ class RedditRedirectExtractor(Extractor):
                r"/s/([a-zA-Z0-9]{10})")
     example = "https://www.reddit.com/r/SUBREDDIT/s/abc456GHIJ"
 
-    def __init__(self, match):
-        Extractor.__init__(self, match)
-        self.sub_type = "user" if match.group(1) == "u" else match.group(1)
-        self.subreddit = match.group(2)
-        self.share_url = match.group(3)
-
     def items(self):
-        url = "https://www.reddit.com/" + self.sub_type + "/" + \
-              self.subreddit + "/s/" + self.share_url
+        sub_type, subreddit, share_url = self.groups
+        if sub_type == "u":
+            sub_type = "user"
+        url = "https://www.reddit.com/{}/{}/s/{}".format(
+            sub_type, subreddit, share_url)
         data = {"_extractor": RedditSubmissionExtractor}
         response = self.request(url, method="HEAD", allow_redirects=False,
                                 notfound="submission")