From df7cdb648a9ba5dcfca8520e6575658e51f0ba8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20F=C3=A4hrmann?= Date: Mon, 29 Apr 2019 17:22:40 +0200 Subject: [PATCH] specify maximum versions for requests & urllib3 (#229) Wouldn't be necessary if pip would do proper version management. As things are right now, pip ignores the urllib3 version requirements from requests because gallery-dl is specifying its own. --- requirements.txt | 4 ++-- setup.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/requirements.txt b/requirements.txt index 66fe7e3d..5301ca87 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,2 +1,2 @@ -requests>=2.11.0 -urllib3>=1.16, !=1.24.1, !=1.24.2 +requests>=2.11.0, <2.22.0 +urllib3>=1.16, <1.25, !=1.24.1, !=1.24.2 diff --git a/setup.py b/setup.py index d83cdc07..7485f375 100644 --- a/setup.py +++ b/setup.py @@ -102,8 +102,8 @@ setup( license="GPLv2", python_requires=">=3.4", install_requires=[ - "requests>=2.11.0", - "urllib3>=1.16, !=1.24.1, !=1.24.2", + "requests>=2.11.0, <2.22.0", + "urllib3>=1.16, <1.25, !=1.24.1, !=1.24.2", ], packages=[ "gallery_dl",