1
0
mirror of https://github.com/imapsync/imapsync.git synced 2024-11-17 08:12:48 +01:00
imapsync/W/perlcritic_3.txt

115 lines
8.5 KiB
Plaintext
Raw Normal View History

2018-05-07 16:04:23 +02:00
Main code has high complexity score (405) at line 1, column 1. Consider refactoring. (Severity: 3)
Regular expression without "/x" flag at line 1560, column 47. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 1569, column 47. See page 236 of PBP. (Severity: 3)
Code structure is deeply nested at line 2110, column 41. Consider refactoring. (Severity: 3)
Too many arguments at line 3443, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 3461, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 3471, column 1. See page 182 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 3616, column 23. See page 236 of PBP. (Severity: 3)
Use "<>" or "<ARGV>" or a prompting module instead of "<STDIN>" at line 3793, column 24. See pages 216,220,221 of PBP. (Severity: 4)
Regular expression without "/x" flag at line 4060, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4061, column 33. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4070, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4081, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4102, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4192, column 64. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4195, column 56. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4196, column 56. See page 236 of PBP. (Severity: 3)
Too many arguments at line 4223, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "authenticate_imap" with high complexity score (21) at line 4303, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 4303, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 4443, column 1. See page 182 of PBP. (Severity: 3)
Use "local $/ = undef" or Path::Tiny instead of joined readline at line 4537, column 43. See page 213 of PBP. (Severity: 3)
Backtick operator used at line 4555, column 20. Use IPC::Open3 instead. (Severity: 3)
Expression form of "eval" at line 5785, column 27. See page 161 of PBP. (Severity: 5)
Single-quote used as quote-like operator delimiter at line 5929, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3)
Expression form of "eval" at line 6030, column 27. See page 161 of PBP. (Severity: 5)
Subroutine "copy_message" with high complexity score (22) at line 6423, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 6423, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 6501, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "message_for_host2" with high complexity score (24) at line 6534, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 6534, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 6846, column 1. See page 182 of PBP. (Severity: 3)
Expression form of "eval" at line 8273, column 27. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 8512, column 27. See page 161 of PBP. (Severity: 5)
Too many arguments at line 8777, column 1. See page 182 of PBP. (Severity: 3)
Literal line breaks in a string at line 9039, column 1. See pages 60,61 of PBP. (Severity: 3)
Backtick operator used at line 9063, column 17. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 9151, column 32. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 9155, column 32. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 9174, column 33. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 9185, column 24. See page 261 of PBP. (Severity: 3)
Cascading if-elsif chain at line 9434, column 2. See pages 117,118 of PBP. (Severity: 3)
Return value of eval not tested at line 9575, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
Backtick operator used at line 9576, column 15. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 9585, column 16. See page 261 of PBP. (Severity: 3)
Return value of eval not tested at line 9598, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
Capture variable used outside conditional at line 9609, column 12. See page 253 of PBP. (Severity: 3)
Backtick operator used at line 9744, column 26. Use IPC::Open3 instead. (Severity: 3)
Backtick operator used at line 9772, column 18. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 9974, column 19. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10000, column 19. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10041, column 19. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10053, column 19. See page 261 of PBP. (Severity: 3)
Hard tabs used at line 10235, column 84. See page 20 of PBP. (Severity: 3)
Expression form of "eval" at line 10276, column 56. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 10280, column 58. See page 161 of PBP. (Severity: 5)
Split long regexps into smaller qr// chunks at line 10738, column 20. See page 261 of PBP. (Severity: 3)
Close filehandles as soon as possible after opening them at line 11049, column 9. See page 209 of PBP. (Severity: 4)
Ambiguously named variable "last" at line 11072, column 2. See page 48 of PBP. (Severity: 3)
Reused variable name in lexical scope: $err at line 11354, column 3. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $err at line 11421, column 3. Invent unique variable names. (Severity: 3)
Hard tabs used at line 11492, column 44. See page 20 of PBP. (Severity: 3)
Magic variable "$SIG" should be assigned as "local" at line 11744, column 33. See pages 81,82 of PBP. (Severity: 4)
"warn" used instead of "carp" at line 11844, column 25. See page 283 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 11858, column 40. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 11860, column 23. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 11861, column 23. See page 236 of PBP. (Severity: 3)
Literal line breaks in a string at line 11884, column 19. See pages 60,61 of PBP. (Severity: 3)
Subroutine "myGetOptions" with high complexity score (29) at line 11919, column 1. Consider refactoring. (Severity: 3)
Capture variable used outside conditional at line 11950, column 41. See page 253 of PBP. (Severity: 3)
1 files.
394 subroutines/methods.
12,987 statements.
12,805 lines, consisting of:
2,409 blank lines.
827 comment lines.
0 data lines.
8,898 lines of Perl code.
671 lines of POD.
Average McCabe score of subroutines was 4.06.
70 violations.
Violations per file was 70.000.
Violations per statement was 0.005.
Violations per line of code was 0.005.
6 severity 5 violations.
3 severity 4 violations.
61 severity 3 violations.
6 violations of BuiltinFunctions::ProhibitStringyEval.
2 violations of CodeLayout::ProhibitHardTabs.
1 violations of ControlStructures::ProhibitCascadingIfElse.
1 violations of ControlStructures::ProhibitDeepNests.
1 violations of ErrorHandling::RequireCarping.
2 violations of ErrorHandling::RequireCheckingReturnValueOfEval.
5 violations of InputOutput::ProhibitBacktickOperators.
1 violations of InputOutput::ProhibitExplicitStdin.
1 violations of InputOutput::ProhibitJoinedReadline.
1 violations of InputOutput::RequireBriefOpen.
1 violations of Modules::ProhibitExcessMainComplexity.
1 violations of NamingConventions::ProhibitAmbiguousNames.
2 violations of RegularExpressions::ProhibitCaptureWithoutTest.
10 violations of RegularExpressions::ProhibitComplexRegexes.
14 violations of RegularExpressions::RequireExtendedFormatting.
4 violations of Subroutines::ProhibitExcessComplexity.
11 violations of Subroutines::ProhibitManyArgs.
2 violations of ValuesAndExpressions::ProhibitImplicitNewlines.
1 violations of ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters.
2 violations of Variables::ProhibitReusedNames.
1 violations of Variables::RequireLocalizedPunctuationVars.