1
0
mirror of https://github.com/imapsync/imapsync.git synced 2024-11-17 00:02:29 +01:00
imapsync/W/perlcritic_3.txt
Nick Bebout 62531f58cd 1.920
2019-07-02 18:17:46 -05:00

118 lines
9.0 KiB
Plaintext

Main code has high complexity score (411) at line 1, column 1. Consider refactoring. (Severity: 3)
"%h1" is declared but not used at line 846, column 1. Unused variables clutter code and make it harder to read. (Severity: 3)
"%h2" is declared but not used at line 846, column 1. Unused variables clutter code and make it harder to read. (Severity: 3)
Regular expression without "/x" flag at line 1579, column 47. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 1588, column 47. See page 236 of PBP. (Severity: 3)
Code structure is deeply nested at line 2151, column 41. Consider refactoring. (Severity: 3)
Regular expression without "/x" flag at line 3010, column 23. See page 236 of PBP. (Severity: 3)
Too many arguments at line 4013, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 4032, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 4053, column 1. See page 182 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4211, column 23. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4735, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4736, column 33. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4745, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4762, column 42. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4791, column 50. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4896, column 64. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4897, column 64. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 4900, column 56. See page 236 of PBP. (Severity: 3)
Too many arguments at line 4928, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "authenticate_imap" with high complexity score (23) at line 5010, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 5010, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 5162, column 1. See page 182 of PBP. (Severity: 3)
Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5259, column 43. See page 213 of PBP. (Severity: 3)
Backtick operator used at line 5277, column 20. Use IPC::Open3 instead. (Severity: 3)
Regular expression without "/x" flag at line 5415, column 26. See page 236 of PBP. (Severity: 3)
Expression form of "eval" at line 6605, column 27. See page 161 of PBP. (Severity: 5)
Single-quote used as quote-like operator delimiter at line 6755, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3)
Expression form of "eval" at line 6846, column 27. See page 161 of PBP. (Severity: 5)
Subroutine "copy_message" with high complexity score (22) at line 7277, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 7277, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 7351, column 1. See page 182 of PBP. (Severity: 3)
Subroutine "message_for_host2" with high complexity score (23) at line 7385, column 1. Consider refactoring. (Severity: 3)
Too many arguments at line 7385, column 1. See page 182 of PBP. (Severity: 3)
Reused variable name in lexical scope: $uid1 at line 7615, column 9. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $uid2 at line 7615, column 9. Invent unique variable names. (Severity: 3)
Too many arguments at line 7811, column 1. See page 182 of PBP. (Severity: 3)
Too many arguments at line 8050, column 1. See page 182 of PBP. (Severity: 3)
Expression form of "eval" at line 9403, column 27. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 9644, column 27. See page 161 of PBP. (Severity: 5)
Too many arguments at line 9955, column 1. See page 182 of PBP. (Severity: 3)
Backtick operator used at line 10254, column 17. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10343, column 32. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10347, column 32. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10366, column 33. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10377, column 24. See page 261 of PBP. (Severity: 3)
Cascading if-elsif chain at line 10641, column 2. See pages 117,118 of PBP. (Severity: 3)
Return value of eval not tested at line 10795, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
Backtick operator used at line 10796, column 15. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10805, column 16. See page 261 of PBP. (Severity: 3)
Return value of eval not tested at line 10818, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
Backtick operator used at line 10819, column 15. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 10828, column 16. See page 261 of PBP. (Severity: 3)
Return value of eval not tested at line 10842, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3)
Capture variable used outside conditional at line 10853, column 12. See page 253 of PBP. (Severity: 3)
Backtick operator used at line 10998, column 26. Use IPC::Open3 instead. (Severity: 3)
Backtick operator used at line 11027, column 18. Use IPC::Open3 instead. (Severity: 3)
Split long regexps into smaller qr// chunks at line 11239, column 19. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 11265, column 19. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 11306, column 19. See page 261 of PBP. (Severity: 3)
Split long regexps into smaller qr// chunks at line 11318, column 19. See page 261 of PBP. (Severity: 3)
Expression form of "eval" at line 11675, column 56. See page 161 of PBP. (Severity: 5)
Expression form of "eval" at line 11679, column 58. See page 161 of PBP. (Severity: 5)
Split long regexps into smaller qr// chunks at line 12145, column 20. See page 261 of PBP. (Severity: 3)
Ambiguously named variable "last" at line 12548, column 2. See page 48 of PBP. (Severity: 3)
Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12602, column 1. See page 197 of PBP. (Severity: 4)
Reused variable name in lexical scope: $err at line 12901, column 3. Invent unique variable names. (Severity: 3)
Reused variable name in lexical scope: $err at line 12971, column 3. Invent unique variable names. (Severity: 3)
"warn" used instead of "carp" at line 13429, column 25. See page 283 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 13446, column 40. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 13448, column 23. See page 236 of PBP. (Severity: 3)
Regular expression without "/x" flag at line 13449, column 23. See page 236 of PBP. (Severity: 3)
Literal line breaks in a string at line 13475, column 19. See pages 60,61 of PBP. (Severity: 3)
Subroutine "myGetOptions" with high complexity score (29) at line 13511, column 1. Consider refactoring. (Severity: 3)
Capture variable used outside conditional at line 13543, column 41. See page 253 of PBP. (Severity: 3)
1 files.
437 subroutines/methods.
14,225 statements.
14,377 lines, consisting of:
2,697 blank lines.
842 comment lines.
0 data lines.
10,160 lines of Perl code.
678 lines of POD.
Average McCabe score of subroutines was 4.00.
75 violations.
Violations per file was 75.000.
Violations per statement was 0.005.
Violations per line of code was 0.005.
6 severity 5 violations.
1 severity 4 violations.
68 severity 3 violations.
6 violations of BuiltinFunctions::ProhibitStringyEval.
1 violations of ControlStructures::ProhibitCascadingIfElse.
1 violations of ControlStructures::ProhibitDeepNests.
1 violations of ErrorHandling::RequireCarping.
3 violations of ErrorHandling::RequireCheckingReturnValueOfEval.
6 violations of InputOutput::ProhibitBacktickOperators.
1 violations of InputOutput::ProhibitJoinedReadline.
1 violations of Modules::ProhibitExcessMainComplexity.
1 violations of NamingConventions::ProhibitAmbiguousNames.
2 violations of RegularExpressions::ProhibitCaptureWithoutTest.
11 violations of RegularExpressions::ProhibitComplexRegexes.
16 violations of RegularExpressions::RequireExtendedFormatting.
4 violations of Subroutines::ProhibitExcessComplexity.
12 violations of Subroutines::ProhibitManyArgs.
1 violations of Subroutines::RequireFinalReturn.
1 violations of ValuesAndExpressions::ProhibitImplicitNewlines.
1 violations of ValuesAndExpressions::ProhibitQuotesAsQuotelikeOperatorDelimiters.
4 violations of Variables::ProhibitReusedNames.
2 violations of Variables::ProhibitUnusedVariables.