2018-06-13 08:18:24 +02:00
|
|
|
.. _contributing:
|
|
|
|
|
2018-01-07 17:26:35 +01:00
|
|
|
Contributing to Instaloader
|
|
|
|
===========================
|
|
|
|
|
|
|
|
As an open source project, Instaloader heavily depends on the contributions from
|
|
|
|
its community. In this document, we advise on how you may help Instaloader to
|
|
|
|
become an even greater tool.
|
|
|
|
|
|
|
|
Instaloader's development is organized on
|
2018-03-13 13:28:44 +01:00
|
|
|
`GitHub <https://github.com/instaloader/instaloader>`__, where Issues and Pull
|
2018-01-07 17:26:35 +01:00
|
|
|
Requests are discussed.
|
|
|
|
|
|
|
|
Reporting Bugs
|
|
|
|
--------------
|
|
|
|
|
|
|
|
If you encounter a bug, do not hesitate to report it in our
|
2019-08-20 22:05:49 +02:00
|
|
|
`Issue Tracker <https://github.com/instaloader/instaloader/issues>`__. When
|
|
|
|
reporting a problem, please keep the following in mind:
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
- Ensure you **use the latest version** of Instaloader. The currently-installed
|
|
|
|
version can be found out with ``instaloader --version``.
|
|
|
|
|
2019-01-17 11:00:04 +01:00
|
|
|
- Check whether there is a valid solution in our :ref:`troubleshooting` section.
|
|
|
|
|
2018-01-07 17:26:35 +01:00
|
|
|
- Briefly **check whether the bug has already been reported**. If you find an
|
|
|
|
issue reporting the same bug you encountered, comment there rather than
|
2018-06-13 08:18:24 +02:00
|
|
|
opening a new issue. However, if unsure, please create a new issue.
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
- State **how the bug can be reproduced**, i.e. how Instaloader was invoked
|
2018-06-17 18:10:19 +02:00
|
|
|
when the problem occurred (of course, you may anonymize profile names etc.).
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
- Include all **error messages and tracebacks** in the report.
|
|
|
|
|
|
|
|
- If not obvious, describe **which behavior you expected**
|
|
|
|
instead of what actually happened.
|
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
- If we have closed an issue apparently inadvertently or inappropriately, please
|
|
|
|
let us know.
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
Writing Code or Improving the Documentation
|
|
|
|
-------------------------------------------
|
|
|
|
|
|
|
|
Changes of the Instaloader source can be proposed as a
|
2018-03-13 13:28:44 +01:00
|
|
|
`Pull Request <https://github.com/instaloader/instaloader/pulls>`__. There are only
|
2018-01-07 17:26:35 +01:00
|
|
|
few things to consider:
|
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
- Base your Pull Request on the ``master`` branch if it fixes a bug,
|
2020-06-16 21:44:22 +02:00
|
|
|
or the ``upcoming/v4.X`` branch (if it exists at the moment of submitting the PR)
|
|
|
|
otherwise.
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
- We use `Pylint <https://www.pylint.org/>`__ for error and syntax checking of
|
2020-06-16 21:44:22 +02:00
|
|
|
the source and `MyPy <https://github.com/python/mypy>`__ for type checking.
|
|
|
|
Beware that sometimes it might be better to disable a warning rather than
|
|
|
|
adapting the code to a tool's desires.
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
- The documentation source is located in the ``docs`` folder. The file
|
2018-06-17 18:10:19 +02:00
|
|
|
``cli-options.rst`` is merely an RST-formatted copy of ``instaloader --help``
|
2018-06-13 08:18:24 +02:00
|
|
|
output, of which the source is in ``instaloader/__main__.py``.
|
2018-01-07 17:26:35 +01:00
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
Proposing Features
|
|
|
|
------------------
|
2018-01-07 17:26:35 +01:00
|
|
|
|
2019-08-20 22:05:49 +02:00
|
|
|
.. goal-start
|
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
Instaloader's goal is to mimic the browser's behavior to access the data that
|
2019-08-20 22:05:49 +02:00
|
|
|
is available through the Instagram web interface, pack this data into complete
|
|
|
|
and easily-(re)usable python objects, and provide a user interface for the most
|
|
|
|
common downloading and metadata collection tasks, without changing any of the
|
|
|
|
online data.
|
|
|
|
|
|
|
|
.. goal-end
|
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
Prior spending effort on implementing a new feature, it might be appropriate to
|
|
|
|
clarify how it could fit into the project's scope or discuss implementation
|
|
|
|
details. If you feel the need to do so, please create a "feature suggestion".
|
2018-01-07 17:26:35 +01:00
|
|
|
|
|
|
|
- Instaloader already has plenty of features. **Check the documentation**
|
|
|
|
beforehand to ensure your desired suggestion is not already implemented.
|
|
|
|
|
|
|
|
- Briefly **ensure that your idea has not already been suggested**. If you find
|
|
|
|
an issue suggesting the same or a similar feature, share your thoughts in a
|
|
|
|
comment there, instead of opening a new issue.
|
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
- **Motivate the feature**, i.e.
|
|
|
|
|
|
|
|
- Provide us a **use case of the feature**: How could the user
|
|
|
|
invoke the new function? Which problem would it solve? If new information is
|
|
|
|
obtained, how would it be further processed?
|
|
|
|
|
|
|
|
- Describe already-working **alternatives of the feature** and how they
|
2020-06-16 21:44:22 +02:00
|
|
|
compare to your proposed feature.
|
2018-01-07 17:26:35 +01:00
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
- Briefly describe how your suggested feature **conforms with Instaloader's
|
|
|
|
project goal**.
|
2019-08-20 22:05:49 +02:00
|
|
|
|
2020-06-16 20:26:58 +02:00
|
|
|
- Explain your **solution ideas**. Describe your ideas on how the feature could
|
2020-06-16 21:44:22 +02:00
|
|
|
be implemented and the underlying problem could be solved. Also **describe
|
|
|
|
alternatives** that you have considered.
|
2018-06-13 08:18:24 +02:00
|
|
|
|
|
|
|
Donations
|
|
|
|
---------
|
|
|
|
|
|
|
|
.. donations-start
|
|
|
|
|
|
|
|
It is a pleasure for us to share our Instaloader to the world, and we are proud
|
|
|
|
to have attracted such an active and motivating community, with so many users
|
|
|
|
who share their suggestions and ideas with us. Buying a community-sponsored beer
|
|
|
|
or coffee from time to time is very likely to further raise our passion for the
|
|
|
|
development of Instaloader.
|
|
|
|
|
2018-07-23 23:36:46 +02:00
|
|
|
| For donations, we provide a PayPal.Me link and a Bitcoin address.
|
|
|
|
| `PayPal.me/aandergr <https://www.paypal.me/aandergr>`__
|
|
|
|
| BTC: 1Nst4LoadeYzrKjJ1DX9CpbLXBYE9RKLwY
|
2018-06-13 08:18:24 +02:00
|
|
|
|
|
|
|
.. donations-end
|
|
|
|
|
|
|
|
.. (Discussion in :issue:`130`)
|