- When a post contained sidecars, the filename for caption, json etc. was changed. It was no longer the original filename like before.
- If the post contains sidecars, a local variable is used to build the filenames for the sidecar media.
This fetch was done for sidecar posts that contain a video when going
through a profile. The fetched information is already present with the
new profile query introduced in the last commit, making this full
metadata fetch query unnecessary. Instaloader now better evaluates if
that fetch must be done or not.
The fetch was also (eventually unnecessarily) made when accessing
get_sidecar_posts() on a Post that has been loaded with
load_structure_from_file().
- It's necessary because for the old query_hash IG isn't returning the full structure any more.
- So the old query_hash is replaced with the current one.
Remove unnecessary queries when a file in a target does not have to be
re-downloaded.
This significantly speeds up the download in cases where the majority of media
is already present locally.
Co-Authored-By: André Koch-Kramer <koch-kramer@web.de>
Avoid evaluating 'url' when preparing the filename if the
filename-pattern does not contain the "{filename}" token. This avoids
the URL to be queried even though it is not needed (e.g. with
--no-pictures).
Fixes efficiency of the download_profiles() function when called with
--no-posts --no-profile-pic by reordering an if statement.
This inefficiency has been reported in #724.
Co-authored-by: André Koch-Kramer <koch-kramer@web.de>
Allows to open the firefox cookie database even though Firefox is
holding a lock.
Fixes the "Cookie import failed: database is locked" message when using
the script while Firefox was running.
This has been reported in #877.
