1
0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2024-09-20 08:21:34 +02:00
invoiceninja/app/Console/Commands/CheckData.php

385 lines
16 KiB
PHP
Raw Normal View History

2016-07-21 14:35:23 +02:00
<?php namespace App\Console\Commands;
2015-03-16 22:45:25 +01:00
2015-05-05 11:48:23 +02:00
use DB;
use Carbon;
2015-03-16 22:45:25 +01:00
use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputOption;
/*
##################################################################
2016-08-25 16:29:55 +02:00
WARNING: Please backup your database before running this script
2015-03-16 22:45:25 +01:00
##################################################################
2016-08-25 16:29:55 +02:00
Since the application was released a number of bugs have inevitably been found.
2015-03-16 22:45:25 +01:00
Although the bugs have always been fixed in some cases they've caused the client's
balance, paid to date and/or activity records to become inaccurate. This script will
check for errors and correct the data.
If you have any questions please email us at contact@invoiceninja.com
Usage:
php artisan ninja:check-data
Options:
2016-08-25 16:29:55 +02:00
--client_id:<value>
2015-03-16 22:45:25 +01:00
Limits the script to a single client
--fix=true
By default the script only checks for errors, adding this option
makes the script apply the fixes.
*/
/**
* Class CheckData
*/
2015-03-16 22:45:25 +01:00
class CheckData extends Command {
/**
* @var string
*/
2015-03-16 22:45:25 +01:00
protected $name = 'ninja:check-data';
/**
* @var string
*/
2015-03-16 22:45:25 +01:00
protected $description = 'Check/fix data';
2016-08-25 16:29:55 +02:00
2015-03-16 22:45:25 +01:00
public function fire()
{
$this->info(date('Y-m-d') . ' Running CheckData...');
if (!$this->option('client_id')) {
2015-12-02 14:26:06 +01:00
$this->checkPaidToDate();
2016-08-29 17:03:08 +02:00
$this->checkBlankInvoiceHistory();
2015-12-02 14:26:06 +01:00
}
$this->checkBalances();
2016-08-29 17:03:08 +02:00
if (!$this->option('client_id')) {
$this->checkAccountData();
}
2015-12-02 14:26:06 +01:00
$this->info('Done');
}
2016-08-29 17:03:08 +02:00
private function checkBlankInvoiceHistory()
{
$count = DB::table('activities')
->where('activity_type_id', '=', 5)
->where('json_backup', '=', '')
->count();
$this->info($count . ' activities with blank invoice backup');
}
2015-12-09 16:47:14 +01:00
private function checkAccountData()
2015-12-02 14:26:06 +01:00
{
2015-12-09 16:47:14 +01:00
$tables = [
'activities' => [
ENTITY_INVOICE,
ENTITY_CLIENT,
ENTITY_CONTACT,
ENTITY_PAYMENT,
ENTITY_INVITATION,
ENTITY_USER
],
'invoices' => [
ENTITY_CLIENT,
ENTITY_USER
],
'payments' => [
ENTITY_INVOICE,
ENTITY_CLIENT,
ENTITY_USER,
ENTITY_INVITATION,
ENTITY_CONTACT
],
'tasks' => [
ENTITY_INVOICE,
ENTITY_CLIENT,
ENTITY_USER
],
'credits' => [
ENTITY_CLIENT,
ENTITY_USER
],
2016-08-29 17:03:08 +02:00
'expenses' => [
ENTITY_CLIENT,
ENTITY_VENDOR,
ENTITY_INVOICE,
ENTITY_USER
]
2015-12-02 14:26:06 +01:00
];
2015-12-09 16:47:14 +01:00
foreach ($tables as $table => $entityTypes) {
foreach ($entityTypes as $entityType) {
$records = DB::table($table)
->join("{$entityType}s", "{$entityType}s.id", '=', "{$table}.{$entityType}_id");
2015-12-02 14:26:06 +01:00
2015-12-09 16:47:14 +01:00
if ($entityType != ENTITY_CLIENT) {
$records = $records->join('clients', 'clients.id', '=', "{$table}.client_id");
}
2016-08-25 16:29:55 +02:00
2015-12-09 16:47:14 +01:00
$records = $records->where("{$table}.account_id", '!=', DB::raw("{$entityType}s.account_id"))
->get(["{$table}.id", 'clients.account_id', 'clients.user_id']);
2015-12-09 16:47:14 +01:00
if (count($records)) {
$this->info(count($records) . " {$table} records with incorrect {$entityType} account id");
if ($this->option('fix') == 'true') {
foreach ($records as $record) {
DB::table($table)
->where('id', $record->id)
->update([
'account_id' => $record->account_id,
'user_id' => $record->user_id,
]);
}
}
2015-03-16 22:45:25 +01:00
}
}
}
2015-12-02 14:26:06 +01:00
}
private function checkPaidToDate()
{
// update client paid_to_date value
$clients = DB::table('clients')
->join('payments', 'payments.client_id', '=', 'clients.id')
->join('invoices', 'invoices.id', '=', 'payments.invoice_id')
->where('payments.is_deleted', '=', 0)
2016-08-25 16:29:55 +02:00
->where('payments.payment_status_id', '!=', 2)
->where('payments.payment_status_id', '!=', 3)
2015-12-02 14:26:06 +01:00
->where('invoices.is_deleted', '=', 0)
->groupBy('clients.id')
2016-08-25 16:29:55 +02:00
->havingRaw('clients.paid_to_date != sum(payments.amount - payments.refunded) and clients.paid_to_date != 999999999.9999')
2015-12-02 14:26:06 +01:00
->get(['clients.id', 'clients.paid_to_date', DB::raw('sum(payments.amount) as amount')]);
$this->info(count($clients) . ' clients with incorrect paid to date');
2016-08-25 16:29:55 +02:00
2015-12-02 14:26:06 +01:00
if ($this->option('fix') == 'true') {
foreach ($clients as $client) {
DB::table('clients')
->where('id', $client->id)
->update(['paid_to_date' => $client->amount]);
}
}
}
2015-03-16 22:45:25 +01:00
2015-12-02 14:26:06 +01:00
private function checkBalances()
{
2015-03-16 22:45:25 +01:00
// find all clients where the balance doesn't equal the sum of the outstanding invoices
$clients = DB::table('clients')
->join('invoices', 'invoices.client_id', '=', 'clients.id')
2016-08-29 17:03:08 +02:00
->join('accounts', 'accounts.id', '=', 'clients.account_id')
->where('clients.is_deleted', '=', 0)
->where('invoices.is_deleted', '=', 0)
2016-05-26 16:56:54 +02:00
->where('invoices.invoice_type_id', '=', INVOICE_TYPE_STANDARD)
2015-03-16 22:45:25 +01:00
->where('invoices.is_recurring', '=', 0)
->havingRaw('abs(clients.balance - sum(invoices.balance)) > .01 and clients.balance != 999999999.9999');
2016-08-25 16:29:55 +02:00
2016-08-29 17:03:08 +02:00
if ($this->option('client_id')) {
$clients->where('clients.id', '=', $this->option('client_id'));
}
2015-03-16 22:45:25 +01:00
$clients = $clients->groupBy('clients.id', 'clients.balance', 'clients.created_at')
2016-08-25 16:29:55 +02:00
->orderBy('accounts.company_id', 'DESC')
->get(['accounts.company_id', 'clients.account_id', 'clients.id', 'clients.balance', 'clients.paid_to_date', DB::raw('sum(invoices.balance) actual_balance')]);
2015-03-16 22:45:25 +01:00
$this->info(count($clients) . ' clients with incorrect balance/activities');
foreach ($clients as $client) {
2016-08-25 16:29:55 +02:00
$this->info("=== Company: {$client->company_id} Account:{$client->account_id} Client:{$client->id} Balance:{$client->balance} Actual Balance:{$client->actual_balance} ===");
2016-07-21 14:35:23 +02:00
$foundProblem = false;
2015-03-16 22:45:25 +01:00
$lastBalance = 0;
2015-05-05 11:48:23 +02:00
$lastAdjustment = 0;
$lastCreatedAt = null;
2015-03-16 22:45:25 +01:00
$clientFix = false;
$activities = DB::table('activities')
->where('client_id', '=', $client->id)
->orderBy('activities.id')
2016-07-21 14:35:23 +02:00
->get(['activities.id', 'activities.created_at', 'activities.activity_type_id', 'activities.adjustment', 'activities.balance', 'activities.invoice_id']);
//$this->info(var_dump($activities));
2015-03-16 22:45:25 +01:00
foreach ($activities as $activity) {
$activityFix = false;
if ($activity->invoice_id) {
$invoice = DB::table('invoices')
->where('id', '=', $activity->invoice_id)
2016-05-26 16:56:54 +02:00
->first(['invoices.amount', 'invoices.is_recurring', 'invoices.invoice_type_id', 'invoices.deleted_at', 'invoices.id', 'invoices.is_deleted']);
2015-03-16 22:45:25 +01:00
// Check if this invoice was once set as recurring invoice
2015-09-17 21:01:06 +02:00
if ($invoice && !$invoice->is_recurring && DB::table('invoices')
2015-03-16 22:45:25 +01:00
->where('recurring_invoice_id', '=', $activity->invoice_id)
->first(['invoices.id'])) {
$invoice->is_recurring = 1;
// **Fix for enabling a recurring invoice to be set as non-recurring**
if ($this->option('fix') == 'true') {
DB::table('invoices')
->where('id', $invoice->id)
->update(['is_recurring' => 1]);
}
}
}
if ($activity->activity_type_id == ACTIVITY_TYPE_CREATE_INVOICE
|| $activity->activity_type_id == ACTIVITY_TYPE_CREATE_QUOTE) {
2016-08-25 16:29:55 +02:00
2015-03-16 22:45:25 +01:00
// Get original invoice amount
$update = DB::table('activities')
->where('invoice_id', '=', $activity->invoice_id)
->where('activity_type_id', '=', ACTIVITY_TYPE_UPDATE_INVOICE)
->orderBy('id')
->first(['json_backup']);
if ($update) {
$backup = json_decode($update->json_backup);
$invoice->amount = floatval($backup->amount);
}
$noAdjustment = $activity->activity_type_id == ACTIVITY_TYPE_CREATE_INVOICE
&& $activity->adjustment == 0
&& $invoice->amount > 0;
2016-08-29 17:03:08 +02:00
// **Fix for ninja invoices which didn't have the invoice_type_id value set
if ($noAdjustment && $client->account_id == 20432) {
$this->info("No adjustment for ninja invoice");
$foundProblem = true;
$clientFix += $invoice->amount;
$activityFix = $invoice->amount;
2015-03-16 22:45:25 +01:00
// **Fix for allowing converting a recurring invoice to a normal one without updating the balance**
2016-08-29 17:03:08 +02:00
} elseif ($noAdjustment && $invoice->invoice_type_id == INVOICE_TYPE_STANDARD && !$invoice->is_recurring) {
2016-05-26 16:56:54 +02:00
$this->info("No adjustment for new invoice:{$activity->invoice_id} amount:{$invoice->amount} invoiceTypeId:{$invoice->invoice_type_id} isRecurring:{$invoice->is_recurring}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
$clientFix += $invoice->amount;
$activityFix = $invoice->amount;
// **Fix for updating balance when creating a quote or recurring invoice**
2016-05-26 16:56:54 +02:00
} elseif ($activity->adjustment != 0 && ($invoice->invoice_type_id == INVOICE_TYPE_QUOTE || $invoice->is_recurring)) {
$this->info("Incorrect adjustment for new invoice:{$activity->invoice_id} adjustment:{$activity->adjustment} invoiceTypeId:{$invoice->invoice_type_id} isRecurring:{$invoice->is_recurring}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
$clientFix -= $activity->adjustment;
$activityFix = 0;
}
} elseif ($activity->activity_type_id == ACTIVITY_TYPE_DELETE_INVOICE) {
// **Fix for updating balance when deleting a recurring invoice**
if ($activity->adjustment != 0 && $invoice->is_recurring) {
$this->info("Incorrect adjustment for deleted invoice adjustment:{$activity->adjustment}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
if ($activity->balance != $lastBalance) {
$clientFix -= $activity->adjustment;
}
$activityFix = 0;
}
} elseif ($activity->activity_type_id == ACTIVITY_TYPE_ARCHIVE_INVOICE) {
// **Fix for updating balance when archiving an invoice**
if ($activity->adjustment != 0 && !$invoice->is_recurring) {
$this->info("Incorrect adjustment for archiving invoice adjustment:{$activity->adjustment}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
$activityFix = 0;
$clientFix += $activity->adjustment;
}
} elseif ($activity->activity_type_id == ACTIVITY_TYPE_UPDATE_INVOICE) {
// **Fix for updating balance when updating recurring invoice**
if ($activity->adjustment != 0 && $invoice->is_recurring) {
$this->info("Incorrect adjustment for updated recurring invoice adjustment:{$activity->adjustment}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
$clientFix -= $activity->adjustment;
$activityFix = 0;
2015-05-05 11:48:23 +02:00
} else if ((strtotime($activity->created_at) - strtotime($lastCreatedAt) <= 1) && $activity->adjustment > 0 && $activity->adjustment == $lastAdjustment) {
$this->info("Duplicate adjustment for updated invoice adjustment:{$activity->adjustment}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-05-05 11:48:23 +02:00
$clientFix -= $activity->adjustment;
$activityFix = 0;
2015-03-16 22:45:25 +01:00
}
} elseif ($activity->activity_type_id == ACTIVITY_TYPE_UPDATE_QUOTE) {
// **Fix for updating balance when updating a quote**
if ($activity->balance != $lastBalance) {
$this->info("Incorrect adjustment for updated quote adjustment:{$activity->adjustment}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
$clientFix += $lastBalance - $activity->balance;
$activityFix = 0;
}
} else if ($activity->activity_type_id == ACTIVITY_TYPE_DELETE_PAYMENT) {
2015-09-20 23:05:02 +02:00
// **Fix for deleting payment after deleting invoice**
2015-03-16 22:45:25 +01:00
if ($activity->adjustment != 0 && $invoice->is_deleted && $activity->created_at > $invoice->deleted_at) {
$this->info("Incorrect adjustment for deleted payment adjustment:{$activity->adjustment}");
2016-07-21 14:35:23 +02:00
$foundProblem = true;
2015-03-16 22:45:25 +01:00
$activityFix = 0;
$clientFix -= $activity->adjustment;
}
}
if ($activityFix !== false || $clientFix !== false) {
$data = [
'balance' => $activity->balance + $clientFix
];
if ($activityFix !== false) {
$data['adjustment'] = $activityFix;
}
if ($this->option('fix') == 'true') {
DB::table('activities')
->where('id', $activity->id)
->update($data);
}
}
$lastBalance = $activity->balance;
2015-05-05 11:48:23 +02:00
$lastAdjustment = $activity->adjustment;
$lastCreatedAt = $activity->created_at;
2015-03-16 22:45:25 +01:00
}
2015-05-05 11:48:23 +02:00
if ($activity->balance + $clientFix != $client->actual_balance) {
$this->info("** Creating 'recovered update' activity **");
2015-03-16 22:45:25 +01:00
if ($this->option('fix') == 'true') {
2015-05-05 11:48:23 +02:00
DB::table('activities')->insert([
'created_at' => new Carbon,
'updated_at' => new Carbon,
'account_id' => $client->account_id,
'client_id' => $client->id,
'adjustment' => $client->actual_balance - $activity->balance,
'balance' => $client->actual_balance,
]);
2015-03-16 22:45:25 +01:00
}
}
2015-05-05 11:48:23 +02:00
$data = ['balance' => $client->actual_balance];
$this->info("Corrected balance:{$client->actual_balance}");
if ($this->option('fix') == 'true') {
DB::table('clients')
->where('id', $client->id)
->update($data);
}
2015-03-16 22:45:25 +01:00
}
}
/**
* @return array
*/
2015-03-16 22:45:25 +01:00
protected function getArguments()
{
return [];
2015-03-16 22:45:25 +01:00
}
/**
* @return array
*/
2015-03-16 22:45:25 +01:00
protected function getOptions()
{
return [
['fix', null, InputOption::VALUE_OPTIONAL, 'Fix data', null],
['client_id', null, InputOption::VALUE_OPTIONAL, 'Client id', null],
];
2015-03-16 22:45:25 +01:00
}
2016-08-25 16:29:55 +02:00
}