From 0479b1abbd75e017b67b91219ffbcf09e031275d Mon Sep 17 00:00:00 2001 From: David Bomba Date: Thu, 9 Feb 2023 12:10:08 +1100 Subject: [PATCH] Fixes for job middleware --- app/Jobs/Util/Import.php | 12 +++++++----- app/Services/Bank/BankMatchingService.php | 11 +++-------- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/app/Jobs/Util/Import.php b/app/Jobs/Util/Import.php index 9af4997318..cf94a27765 100644 --- a/app/Jobs/Util/Import.php +++ b/app/Jobs/Util/Import.php @@ -106,6 +106,7 @@ class Import implements ShouldQueue use CleanLineItems; use Uploadable; use SavesDocuments; + /** * @var array */ @@ -188,10 +189,10 @@ class Import implements ShouldQueue $this->resources = $resources; } - // public function middleware() - // { - // return [new WithoutOverlapping("only_one_migration_at_a_time_ever")]; - // } + public function middleware() + { + return [(new WithoutOverlapping($this->user->account_id))]; + } /** * Execute the job. @@ -1897,6 +1898,8 @@ class Import implements ShouldQueue { info('the job failed'); + config(['queue.failed.driver' => null]); + $job_failure = new MigrationFailure(); $job_failure->string_metric5 = get_class($this); $job_failure->string_metric6 = $exception->getMessage(); @@ -1951,7 +1954,6 @@ class Import implements ShouldQueue } - /* In V4 we use negative invoices (credits) and add then into the client balance. In V5, these sit off ledger and are applied later. This next section will check for credit balances and reduce the client balance so that the V5 balances are correct */ diff --git a/app/Services/Bank/BankMatchingService.php b/app/Services/Bank/BankMatchingService.php index 25c8cbf480..663e720411 100644 --- a/app/Services/Bank/BankMatchingService.php +++ b/app/Services/Bank/BankMatchingService.php @@ -52,14 +52,9 @@ class BankMatchingService implements ShouldQueue } - /** - * The unique ID of the job. - * - * @return string - */ - public function uniqueId() - { - return (string)$this->company_id; + public function middleware() + { + return [(new WithoutOverlapping($this->company_id))]; } }