Mirrors/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2024-11-10 05:02:36 +01:00
Code Issues Releases Activity

Static Analysis + ACSS

Browse Source
This commit is contained in:
David Bomba 2024-06-17 16:08:06 +10:00
parent 11e082d443
commit 13405c1805
18 changed files with 19 additions and 204 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/CompanyController.php
View File

@ -693,7 +693,7 @@ class CompanyController extends BaseController
public function updateOriginTaxData(DefaultCompanyRequest $request, Company $company) public function updateOriginTaxData(DefaultCompanyRequest $request, Company $company)
{ {
if($company->settings->country_id == "840" && !$company?->account->isFreeHostedClient()) { if($company->settings->country_id == "840" && !$company->account->isFreeHostedClient()) {
try { try {
(new CompanyTaxRate($company))->handle(); (new CompanyTaxRate($company))->handle();
} catch(\Exception $e) { } catch(\Exception $e) {

3
app/Http/Controllers/CompanyUserController.php
View File

@ -119,8 +119,6 @@ class CompanyUserController extends BaseController
if (! $company_user) { if (! $company_user) {
throw new ModelNotFoundException(ctrans('texts.company_user_not_found')); throw new ModelNotFoundException(ctrans('texts.company_user_not_found'));
return;
} }
if ($auth_user->isAdmin()) { if ($auth_user->isAdmin()) {
@ -152,7 +150,6 @@ class CompanyUserController extends BaseController
if (! $company_user) { if (! $company_user) {
throw new ModelNotFoundException(ctrans('texts.company_user_not_found')); throw new ModelNotFoundException(ctrans('texts.company_user_not_found'));
return;
} }
$this->entity_type = User::class; $this->entity_type = User::class;

5
app/Http/Controllers/CreditController.php
View File

@ -594,13 +594,11 @@ class CreditController extends BaseController
$credit->service()->markPaid()->save(); $credit->service()->markPaid()->save();
return $this->itemResponse($credit); return $this->itemResponse($credit);
break;
case 'clone_to_credit': case 'clone_to_credit':
$credit = CloneCreditFactory::create($credit, auth()->user()->id); $credit = CloneCreditFactory::create($credit, auth()->user()->id);
return $this->itemResponse($credit); return $this->itemResponse($credit);
break;
case 'history': case 'history':
// code... // code...
break; break;
@ -617,7 +615,7 @@ class CreditController extends BaseController
return response()->streamDownload(function () use ($file) { return response()->streamDownload(function () use ($file) {
echo $file; echo $file;
}, $credit->numberFormatter() . '.pdf', ['Content-Type' => 'application/pdf']); }, $credit->numberFormatter() . '.pdf', ['Content-Type' => 'application/pdf']);
break;
case 'archive': case 'archive':
$this->credit_repository->archive($credit); $this->credit_repository->archive($credit);
@ -655,7 +653,6 @@ class CreditController extends BaseController
default: default:
return response()->json(['message' => ctrans('texts.action_unavailable', ['action' => $action])], 400); return response()->json(['message' => ctrans('texts.action_unavailable', ['action' => $action])], 400);
break;
} }
} }

18
app/Http/Controllers/EmailController.php
View File

@ -139,19 +139,19 @@ class EmailController extends BaseController
return $this->itemResponse($entity_obj->fresh()); return $this->itemResponse($entity_obj->fresh());
} }
private function sendPurchaseOrder($entity_obj, $data, $template) // private function sendPurchaseOrder($entity_obj, $data, $template)
{ // {
$this->entity_type = PurchaseOrder::class; // $this->entity_type = PurchaseOrder::class;
$this->entity_transformer = PurchaseOrderTransformer::class; // $this->entity_transformer = PurchaseOrderTransformer::class;
$data['template'] = $template; // $data['template'] = $template;
PurchaseOrderEmail::dispatch($entity_obj, $entity_obj->company, $data); // PurchaseOrderEmail::dispatch($entity_obj, $entity_obj->company, $data);
$entity_obj->sendEvent(Webhook::EVENT_SENT_PURCHASE_ORDER, "vendor"); // $entity_obj->sendEvent(Webhook::EVENT_SENT_PURCHASE_ORDER, "vendor");
return $this->itemResponse($entity_obj); // return $this->itemResponse($entity_obj);
} // }
private function resolveClass(string $entity): string private function resolveClass(string $entity): string
{ {

133
app/Http/Controllers/PreviewPurchaseOrderController.php
View File

@ -219,139 +219,6 @@ class PreviewPurchaseOrderController extends BaseController
} }
public function livex(PreviewPurchaseOrderRequest $request)
{
/** @var \App\Models\User $user */
$user = auth()->user();
$company = $user->company();
$file_path = (new PreviewPdf('<html></html>', $company))->handle();
$response = Response::make($file_path, 200);
$response->header('Content-Type', 'application/pdf');
return $response;
MultiDB::setDb($company->db);
$repo = new PurchaseOrderRepository();
$entity_obj = PurchaseOrderFactory::create($company->id, $user->id);
$class = PurchaseOrder::class;
try {
DB::connection(config('database.default'))->beginTransaction();
if ($request->has('entity_id')) {
/** @var \App\Models\PurchaseOrder|\Illuminate\Contracts\Database\Eloquent\Builder $entity_obj **/
$entity_obj = \App\Models\PurchaseOrder::on(config('database.default'))
->with('vendor.company')
->where('id', $this->decodePrimaryKey($request->input('entity_id')))
->where('company_id', $company->id)
->withTrashed()
->first();
}
$entity_obj = $repo->save($request->all(), $entity_obj);
if (!$request->has('entity_id')) {
$entity_obj->service()->fillDefaults()->save();
}
App::forgetInstance('translator');
$t = app('translator');
App::setLocale($entity_obj->company->locale());
$t->replace(Ninja::transformTranslations($entity_obj->company->settings));
$html = new VendorHtmlEngine($entity_obj->invitations()->first());
/** @var \App\Models\Design $design */
$design = \App\Models\Design::withTrashed()->find($entity_obj->design_id);
/* Catch all in case migration doesn't pass back a valid design */
if (!$design) {
$design = \App\Models\Design::find(2);
}
if ($design->is_custom) {
$options = [
'custom_partials' => json_decode(json_encode($design->design), true)
];
$template = new PdfMakerDesign(PdfDesignModel::CUSTOM, $options);
} else {
$template = new PdfMakerDesign(strtolower($design->name));
}
$variables = $html->generateLabelsAndValues();
$state = [
'template' => $template->elements([
'client' => null,
'vendor' => $entity_obj->vendor,
'entity' => $entity_obj,
'pdf_variables' => (array) $entity_obj->company->settings->pdf_variables,
'variables' => $html->generateLabelsAndValues(),
'$product' => $design->design->product,
]),
'variables' => $html->generateLabelsAndValues(),
'options' => [
'client' => null,
'vendor' => $entity_obj->vendor,
'purchase_orders' => [$entity_obj],
'variables' => $html->generateLabelsAndValues(),
],
'process_markdown' => $entity_obj->company->markdown_enabled,
];
$maker = new PdfMaker($state);
$maker
->design($template)
->build();
DB::connection(config('database.default'))->rollBack();
if (request()->query('html') == 'true') {
return $maker->getCompiledHTML();
}
} catch(\Exception $e) {
DB::connection(config('database.default'))->rollBack();
return;
}
/** @var \App\Models\User $user */
$user = auth()->user();
//if phantom js...... inject here..
if (config('ninja.phantomjs_pdf_generation') || config('ninja.pdf_generator') == 'phantom') {
return (new Phantom())->convertHtmlToPdf($maker->getCompiledHTML(true));
}
if (config('ninja.invoiceninja_hosted_pdf_generation') || config('ninja.pdf_generator') == 'hosted_ninja') {
$pdf = (new NinjaPdf())->build($maker->getCompiledHTML(true));
$numbered_pdf = $this->pageNumbering($pdf, $user->company());
if ($numbered_pdf) {
$pdf = $numbered_pdf;
}
return $pdf;
}
$file_path = (new PreviewPdf($maker->getCompiledHTML(true), $company))->handle();
if (Ninja::isHosted()) {
LightLogs::create(new LivePreview())
->increment()
->batch();
}
$response = Response::make($file_path, 200);
$response->header('Content-Type', 'application/pdf');
return $response;
}
private function blankEntity() private function blankEntity()
{ {
/** @var \App\Models\User $user */ /** @var \App\Models\User $user */

1
app/Http/Controllers/ProtectedDownloadController.php
View File

@ -25,7 +25,6 @@ class ProtectedDownloadController extends BaseController
if (!$hashed_path) { if (!$hashed_path) {
throw new SystemError('File no longer available', 404); throw new SystemError('File no longer available', 404);
abort(404, 'File no longer available');
} }
return response()->streamDownload(function () use ($hashed_path) { return response()->streamDownload(function () use ($hashed_path) {

1
app/Http/Controllers/QuoteController.php
View File

@ -787,7 +787,6 @@ class QuoteController extends BaseController
break; break;
default: default:
return response()->json(['message' => ctrans('texts.action_unavailable', ['action' => $action])], 400); return response()->json(['message' => ctrans('texts.action_unavailable', ['action' => $action])], 400);
break;
} }
} }

1
app/Import/Transformer/BaseTransformer.php
View File

@ -658,7 +658,6 @@ class BaseTransformer
public function getExpenseCategoryId($name) public function getExpenseCategoryId($name)
{ {
/** @var \App\Models\ExpenseCategory $ec */ /** @var \App\Models\ExpenseCategory $ec */
$ec = ExpenseCategory::query()->where('company_id', $this->company->id) $ec = ExpenseCategory::query()->where('company_id', $this->company->id)
->where('is_deleted', false) ->where('is_deleted', false)
->whereRaw("LOWER(REPLACE(`name`, ' ' ,'')) = ?", [ ->whereRaw("LOWER(REPLACE(`name`, ' ' ,'')) = ?", [

19
app/Jobs/Company/CompanyImport.php
View File

@ -1205,6 +1205,7 @@ class CompanyImport implements ShouldQueue
continue; continue;
} }
/** @var string $storage_url */
$storage_url = (object)$this->getObject('storage_url', true); $storage_url = (object)$this->getObject('storage_url', true);
if (!Storage::exists($document->url) && is_string($storage_url)) { if (!Storage::exists($document->url) && is_string($storage_url)) {
@ -1351,45 +1352,31 @@ class CompanyImport implements ShouldQueue
switch ($type) { switch ($type) {
case Company::class: case Company::class:
return $this->company->id; return $this->company->id;
break;
case Client::class: case Client::class:
return $this->transformId('clients', $id); return $this->transformId('clients', $id);
break;
case ClientContact::class: case ClientContact::class:
return $this->transformId('client_contacts', $id); return $this->transformId('client_contacts', $id);
break;
case Credit::class: case Credit::class:
return $this->transformId('credits', $id); return $this->transformId('credits', $id);
break;
case Expense::class: case Expense::class:
return $this->transformId('expenses', $id); return $this->transformId('expenses', $id);
break;
case 'invoices': case 'invoices':
return $this->transformId('invoices', $id); return $this->transformId('invoices', $id);
break;
case Payment::class: case Payment::class:
return $this->transformId('payments', $id); return $this->transformId('payments', $id);
break;
case Project::class: case Project::class:
return $this->transformId('projects', $id); return $this->transformId('projects', $id);
break;
case Product::class: case Product::class:
return $this->transformId('products', $id); return $this->transformId('products', $id);
break;
case Quote::class: case Quote::class:
return $this->transformId('quotes', $id); return $this->transformId('quotes', $id);
break;
case RecurringInvoice::class: case RecurringInvoice::class:
return $this->transformId('recurring_invoices', $id); return $this->transformId('recurring_invoices', $id);
break;
case Company::class: case Company::class:
return $this->transformId('clients', $id); return $this->transformId('clients', $id);
break;
default: default:
return false; return false;
break;
} }
} }
@ -1420,10 +1407,10 @@ class CompanyImport implements ShouldQueue
switch ($type) { switch ($type) {
case 'invoices': case 'invoices':
return $this->transformId('invoices', $id); return $this->transformId('invoices', $id);
break;
case Credit::class: case Credit::class:
return $this->transformId('credits', $id); return $this->transformId('credits', $id);
break;
case Payment::class: case Payment::class:
return $this->transformId('payments', $id); return $this->transformId('payments', $id);
default: default:

7
app/Jobs/Util/Import.php
View File

@ -1455,30 +1455,23 @@ class Import implements ShouldQueue
switch ($status_id) { switch ($status_id) {
case 1: case 1:
return $payment; return $payment;
break;
case 2: case 2:
return $payment->service()->deletePayment(); return $payment->service()->deletePayment();
break;
case 3: case 3:
return $payment->service()->deletePayment(); return $payment->service()->deletePayment();
break;
case 4: case 4:
return $payment; return $payment;
break;
case 5: case 5:
$payment->status_id = Payment::STATUS_PARTIALLY_REFUNDED; $payment->status_id = Payment::STATUS_PARTIALLY_REFUNDED;
$payment->save(); $payment->save();
return $payment; return $payment;
break;
case 6: case 6:
$payment->status_id = Payment::STATUS_REFUNDED; $payment->status_id = Payment::STATUS_REFUNDED;
$payment->save(); $payment->save();
return $payment; return $payment;
break;
default: default:
return $payment; return $payment;
break;
} }
} }

12
app/Jobs/Vendor/CreatePurchaseOrderPdf.php vendored
View File

@ -100,18 +100,6 @@ class CreatePurchaseOrderPdf implements ShouldQueue
return $ps->boot()->getPdf(); return $ps->boot()->getPdf();
$pdf = $this->rawPdf();
if ($pdf) {
try {
Storage::disk($this->disk)->put($this->file_path, $pdf);
} catch(\Exception $e) {
throw new FilePermissionsFailure($e->getMessage());
}
}
return $this->file_path;
} }
public function rawPdf() public function rawPdf()

1
app/Libraries/OAuth/OAuth.php
View File

@ -130,7 +130,6 @@ class OAuth
return $this; return $this;
default: default:
return null; return null;
break;
} }
} }

9
app/Mail/Engine/PaymentEmailEngine.php
View File

@ -516,14 +516,5 @@ class PaymentEmailEngine extends BaseEmailEngine
'; ';
return '
<table border="0" cellspacing="0" cellpadding="0" align="center">
<tr style="border: 0 !important; ">
<td class="new_button" style="padding: 12px 18px 12px 18px; border-radius:5px;" align="center">
<a href="'. $link .'" target="_blank" style="border: 0 !important;font-size: 18px; font-family: Helvetica, Arial, sans-serif; color: #ffffff; text-decoration: none; display: inline-block;">'. $text .'</a>
</td>
</tr>
</table>
';
} }
} }

1
app/PaymentDrivers/BraintreePaymentDriver.php
View File

@ -354,7 +354,6 @@ class BraintreePaymentDriver extends BaseDriver
return false; return false;
} }
return false;
} }
private function findTokens(string $gateway_customer_reference) private function findTokens(string $gateway_customer_reference)

4
app/PaymentDrivers/PayPal/PayPalBasePaymentDriver.php
View File

@ -450,11 +450,11 @@ class PayPalBasePaymentDriver extends BaseDriver
switch ($response['name']) { switch ($response['name']) {
case 'NOT_AUTHORIZED': case 'NOT_AUTHORIZED':
throw new PaymentFailed("There was a permissions issue processing this payment, please contact the merchant. ", 401); throw new PaymentFailed("There was a permissions issue processing this payment, please contact the merchant. ", 401);
break;
default: default:
throw new PaymentFailed("Unknown error occurred processing payment. Please contact merchant.", 500); throw new PaymentFailed("Unknown error occurred processing payment. Please contact merchant.", 500);
break;
} }
} }

2
app/Services/Tax/Providers/TaxProvider.php
View File

@ -225,7 +225,7 @@ class TaxProvider
{ {
throw new \Exception("No tax region defined for this country"); throw new \Exception("No tax region defined for this country");
$this->provider = EuTax::class; // $this->provider = EuTax::class;
return $this; return $this;
} }

2
app/Transformers/ProjectTransformer.php
View File

@ -47,7 +47,7 @@ class ProjectTransformer extends EntityTransformer
{ {
$transformer = new DocumentTransformer($this->serializer); $transformer = new DocumentTransformer($this->serializer);
if($project->documents) { if($project->documents->count() > 0) {
return $this->includeCollection($project->documents, $transformer, Document::class); return $this->includeCollection($project->documents, $transformer, Document::class);
} }

2
resources/views/portal/ninja2020/gateways/stripe/acss/authorize.blade.php
View File

@ -34,7 +34,7 @@
<br> <br>
<p>You have certain recourse rights if any debit does not comply with this agreement. For example, you have the right to receive reimbursement for any debit that is not authorized or is not consistent with this PAD Agreement. To obtain more information on your recourse rights, contact your financial institution.</p> <p>You have certain recourse rights if any debit does not comply with this agreement. For example, you have the right to receive reimbursement for any debit that is not authorized or is not consistent with this PAD Agreement. To obtain more information on your recourse rights, contact your financial institution.</p>
<br> <br>
<p>You may amend or cancel this authorization at any time by providing the merchant with thirty (30) days notice at {{ $company->present()->email() }}. To obtain a sample cancellation form, or further information on cancelling a PAD agreement, please contact your financial institution.</p> <p>You may amend or cancel this authorization at any time by providing the merchant with thirty (30) days notice at {{ $company->owner()->email }}. To obtain a sample cancellation form, or further information on cancelling a PAD agreement, please contact your financial institution.</p>
<br> <br>
<p>{{ $company->present()->name() }} partners with Stripe to provide payment processing.</p> <p>{{ $company->present()->name() }} partners with Stripe to provide payment processing.</p>