Improve filtering of Lists by clients

app/Filters/CreditFilters.php

@@ -115,6 +115,11 @@ class CreditFilters extends QueryFilters
             return $this->builder;
         }
 
+        if ($sort_col[0] == 'client_id') {
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                    ->whereColumn('clients.id', 'credits.client_id'), $sort_col[1]);
+        }
+
         return $this->builder->orderBy($sort_col[0], $sort_col[1]);
     }
 

app/Filters/InvoiceFilters.php

@@ -11,12 +11,14 @@
 
 namespace App\Filters;
 
+use RuntimeException;
+use App\Models\Client;
 use App\Models\Invoice;
+use App\Filters\QueryFilters;
+use InvalidArgumentException;
+use Illuminate\Support\Carbon;
 use App\Utils\Traits\MakesHash;
 use Illuminate\Database\Eloquent\Builder;
-use Illuminate\Support\Carbon;
-use InvalidArgumentException;
-use RuntimeException;
 
 /**
  * InvoiceFilters.
@@ -205,10 +207,9 @@ class InvoiceFilters extends QueryFilters
         }
 
         if ($sort_col[0] == 'client_id') {
-        
-            $this->builder->with(['client' => function($q) use($sort_col){
-                        $q->orderBy('name', $sort_col[1]);
-                        }]);
+
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                             ->whereColumn('clients.id', 'invoices.client_id'), $sort_col[1]);
             
         }
 

app/Filters/PaymentFilters.php

@@ -158,6 +158,13 @@ class PaymentFilters extends QueryFilters
             return $this->builder;
         }
 
+
+        if ($sort_col[0] == 'client_id') {
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                    ->whereColumn('clients.id', 'payments.client_id'), $sort_col[1]);
+        }
+
+
         return $this->builder->orderBy($sort_col[0], $sort_col[1]);
     }
 

app/Filters/QuoteFilters.php

@@ -135,6 +135,13 @@ class QuoteFilters extends QueryFilters
             return $this->builder;
         }
 
+        if($sort_col[0] == 'client_id'){
+
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                    ->whereColumn('clients.id', 'quotes.client_id'), $sort_col[1]);
+
+        }
+
         if ($sort_col[0] == 'valid_until') {
             $sort_col[0] = 'due_date';
         }

app/Filters/RecurringInvoiceFilters.php

@@ -115,6 +115,13 @@ class RecurringInvoiceFilters extends QueryFilters
             return $this->builder;
         }
 
+
+        if ($sort_col[0] == 'client_id') {
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                    ->whereColumn('clients.id', 'recurring_invoices.client_id'), $sort_col[1]);
+        }
+
+
         return $this->builder->orderBy($sort_col[0], $sort_col[1]);
     }
 

app/Filters/TaskFilters.php

@@ -110,6 +110,13 @@ class TaskFilters extends QueryFilters
             return $this->builder;
         }
 
+
+        if ($sort_col[0] == 'client_id') {
+            return $this->builder->orderBy(\App\Models\Client::select('name')
+                    ->whereColumn('clients.id', 'tasks.client_id'), $sort_col[1]);
+        }
+
+
         return $this->builder->orderBy($sort_col[0], $sort_col[1]);
     }
 

app/Jobs/Client/UpdateTaxData.php

@@ -146,6 +146,8 @@ class UpdateTaxData implements ShouldQueue
     public function failed($exception)
     {
         nlog("UpdateTaxData failed => ".$exception->getMessage());
+        config(['queue.failed.driver' => null]);
+
     }
 
 }