1
0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2024-09-20 08:21:34 +02:00

Fix inconsistency at ProductRepository (#3209)

- Remove required Request object to be passed
- Use array of data instead
This commit is contained in:
Benjamin Beganović 2020-01-13 23:26:36 +01:00 committed by David Bomba
parent 2c99d3478b
commit 633a75318e
2 changed files with 9 additions and 4 deletions

View File

@ -178,7 +178,7 @@ class ProductController extends BaseController
*/
public function store(StoreProductRequest $request)
{
$product = $this->product_repo->save($request, ProductFactory::create(auth()->user()->company()->id, auth()->user()->id));
$product = $this->product_repo->save($request->all(), ProductFactory::create(auth()->user()->company()->id, auth()->user()->id));
return $this->itemResponse($product);
}

View File

@ -23,10 +23,15 @@ class ProductRepository extends BaseRepository
{
return Product::class;
}
public function save(Request $request, Product $product) : ?Product
/**
* @param array $data
* @param Product $product
* @return Product|null
*/
public function save(array $data, Product $product) : ?Product
{
$product->fill($request->input());
$product->fill($data);
$product->save();
return $product;