1
0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2024-09-20 16:31:33 +02:00

Fixes for reminders

This commit is contained in:
David Bomba 2021-06-15 08:06:01 +10:00
parent 4ce093ff8b
commit 887bc3d4a6
3 changed files with 12 additions and 4 deletions

View File

@ -53,7 +53,11 @@ class ReminderJob implements ShouldQueue
private function processReminders()
{
Invoice::whereDate('next_send_date', '<=', now())->with('invitations')->cursor()->each(function ($invoice) {
Invoice::whereDate('next_send_date', '<=', now())
->where('is_deleted', 0)
->whereIn('status_id', [Invoice::STATUS_SENT, Invoice::STATUS_PARTIAL])
->where('balance', '>', 0)
->with('invitations')->cursor()->each(function ($invoice) {
if ($invoice->isPayable()) {
$reminder_template = $invoice->calculateTemplate('invoice');

View File

@ -392,7 +392,8 @@ class InvoiceService
$this->invoice->reminder_last_sent = now()->format('Y-m-d');
break;
default:
// code...
$this->invoice->reminder1_sent = now()->format('Y-m-d');
$this->invoice->reminder_last_sent = now()->format('Y-m-d');
break;
}

View File

@ -126,8 +126,11 @@ class UpdateReminder extends AbstractService
$date_collection->push($reminder_date);
}
$this->invoice->next_send_date = $date_collection->sort()->first();
if($date_collection->count() >=1)
$this->invoice->next_send_date = $date_collection->sort()->first();
else
$this->invoice->next_send_date = null;
return $this->invoice;
}
}