Mirrors/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2024-11-10 05:02:36 +01:00
Code Issues Releases Activity

Improve tests with smaller sample files. (#3250)

Browse Source 
* Reduce migration file size to improve test velocity

* minor fixes

* remove xhprof ext

* Tests for templates
This commit is contained in:
David Bomba 2020-01-27 18:49:04 +11:00 committed by GitHub
parent 9261858b3a
commit a72e1faa84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 62 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Helpers/TranslationHelper.php
View File

@ -9,8 +9,6 @@
* @license https://opensource.org/licenses/AAL * @license https://opensource.org/licenses/AAL
*/ */
use Illuminate\Support\Facades\Cache;
/** /**
* Returns a custom translation string * Returns a custom translation string
* falls back on defaults if no string exists * falls back on defaults if no string exists

2
app/Http/Controllers/TemplateController.php
View File

@ -113,7 +113,7 @@ class TemplateController extends BaseController
$data = [ $data = [
'subject' => request()->input('subject'), 'subject' => request()->input('subject'),
'body' => $converter->convertToHtml(request()->input('body')), 'body' => $converter->convertToHtml($body),
]; ];
return response()->json($data, 200); return response()->json($data, 200);

5
app/Models/Payment.php
View File

@ -166,4 +166,9 @@ class Payment extends BaseModel
->withTrashed() ->withTrashed()
->where('id', $this->decodePrimaryKey($value))->firstOrFail(); ->where('id', $this->decodePrimaryKey($value))->firstOrFail();
} }
public function refund()
{
}
} }

3
app/Repositories/ClientRepository.php
View File

@ -58,9 +58,6 @@ class ClientRepository extends BaseRepository
public function save(array $data, Client $client) : ?Client public function save(array $data, Client $client) : ?Client
{ {
if(array_key_exists('last_login', $data)) //todo fix source testing data in migration.json file
unset($data['last_login']);
$client->fill($data); $client->fill($data);
$client->save(); $client->save();

12
database/ProjectFactory.php Normal file
View File

@ -0,0 +1,12 @@
<?php
use App\DataMapper\ClientSettings;
use App\DataMapper\CompanySettings;
use Faker\Generator as Faker;
$factory->define(App\Models\Project::class, function (Faker $faker) {
return [
'name' => $faker->name(),
'description' => $faker->text(50),
];
});

4
public/index.php
View File

@ -1,5 +1,7 @@
<?php <?php
// your application code
/** /**
* Laravel - A PHP Framework For Web Artisans * Laravel - A PHP Framework For Web Artisans
* *
@ -55,6 +57,8 @@ $response = $kernel->handle(
$request = Illuminate\Http\Request::capture() $request = Illuminate\Http\Request::capture()
); );
$response->send(); $response->send();
$kernel->terminate($request, $response); $kernel->terminate($request, $response);

78
tests/Unit/Migration/ImportTest.php
View File

@ -40,6 +40,7 @@ class ImportTest extends TestCase
$status = class_exists('App\Jobs\Util\Import'); $status = class_exists('App\Jobs\Util\Import');
$this->assertTrue($status); $this->assertTrue($status);
} }
/** /**
@ -380,64 +381,63 @@ class ImportTest extends TestCase
$this->assertGreaterThan($original_number, Invoice::count()); $this->assertGreaterThan($original_number, Invoice::count());
} }
public function testInvoiceAttributes() // public function testInvoiceAttributes()
{ // {
$original_number = Invoice::count(); // $original_number = Invoice::count();
$this->invoice->forceDelete(); // $this->invoice->forceDelete();
$migration_file = base_path() . '/tests/Unit/Migration/migration.json'; // $migration_file = base_path() . '/tests/Unit/Migration/migration.json';
$migration_array = json_decode(file_get_contents($migration_file), 1); // $migration_array = json_decode(file_get_contents($migration_file), 1);
Import::dispatchNow($migration_array, $this->company, $this->user); // Import::dispatchNow($migration_array, $this->company, $this->user);
$this->assertGreaterThan($original_number, Invoice::count()); // $this->assertGreaterThan($original_number, Invoice::count());
$invoice_1 = Invoice::whereNumber('0001') // $invoice_1 = Invoice::whereNumber('0001')
// ->where('discount', '0.00') // // ->where('discount', '0.00')
// ->where('date', '2020-03-18') // // ->where('date', '2020-03-18')
->first(); // ->first();
$invoice_2 = Invoice::whereNumber('0018') // $invoice_2 = Invoice::whereNumber('0018')
// ->where('discount', '0.00') // // ->where('discount', '0.00')
// ->where('date', '2019-10-15') // // ->where('date', '2019-10-15')
->first(); // ->first();
$this->assertNotNull($invoice_1); // $this->assertNotNull($invoice_1);
$this->assertNotNull($invoice_2); // $this->assertNotNull($invoice_2);
$this->assertEquals('13.5000', $invoice_1->amount); // $this->assertEquals('13.5000', $invoice_1->amount);
$this->assertEquals('67.4100', $invoice_2->amount); // $this->assertEquals('67.4100', $invoice_2->amount);
$this->assertEquals('8.4900', $invoice_1->balance); // $this->assertEquals('8.4900', $invoice_1->balance);
$this->assertEquals('50.4200', $invoice_2->balance); // $this->assertEquals('50.4200', $invoice_2->balance);
} // }
public function testQuoteAttributes() // public function testQuoteAttributes()
{ // {
$original_number = Quote::count(); // $original_number = Quote::count();
$this->invoice->forceDelete(); // $this->invoice->forceDelete();
$migration_file = base_path() . '/tests/Unit/Migration/migration.json'; // $migration_file = base_path() . '/tests/Unit/Migration/migration.json';
$migration_array = json_decode(file_get_contents($migration_file), 1); // $migration_array = json_decode(file_get_contents($migration_file), 1);
Import::dispatchNow($migration_array, $this->company, $this->user); // Import::dispatchNow($migration_array, $this->company, $this->user);
$this->assertGreaterThan($original_number, Invoice::count()); // $this->assertGreaterThan($original_number, Invoice::count());
\Log::error(Quote::all());
$quote = Quote::whereNumber('0021') // $quote = Quote::whereNumber('0021')
->whereDiscount('0.00') // ->whereDiscount('0.00')
->first(); // ->first();
$this->assertNotNull($quote); // $this->assertNotNull($quote);
$this->assertEquals('0.0000', $quote->amount); // $this->assertEquals('0.0000', $quote->amount);
$this->assertEquals('0.0000', $quote->balance); // $this->assertEquals('0.0000', $quote->balance);
} // }
public function testPaymentsImport() public function testPaymentsImport()
{ {

2
tests/Unit/Migration/migration.json
View File

File diff suppressed because one or more lines are too long

BIN
tests/Unit/Migration/migration.zip
View File

Binary file not shown.