From aa9af574b656c9fa77fd41ef3f2bf9b0a4044d4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Beganovi=C4=87?= Date: Thu, 10 Dec 2020 15:04:59 +0100 Subject: [PATCH] Add support for X-Api-Token: --- .../Controllers/Migration/StepsController.php | 3 +- app/Services/Migration/AuthService.php | 29 +++++++++++++++++-- app/Services/Migration/CompleteService.php | 8 ++++- resources/lang/en/texts.php | 3 ++ resources/views/migration/auth.blade.php | 13 +++++++-- 5 files changed, 49 insertions(+), 7 deletions(-) diff --git a/app/Http/Controllers/Migration/StepsController.php b/app/Http/Controllers/Migration/StepsController.php index 52007b8e58..b18eff1d96 100644 --- a/app/Http/Controllers/Migration/StepsController.php +++ b/app/Http/Controllers/Migration/StepsController.php @@ -124,12 +124,13 @@ class StepsController extends BaseController return back()->with('responseErrors', [trans('texts.cross_migration_message')]); } - $authentication = (new AuthService($request->email, $request->password)) + $authentication = (new AuthService($request->email, $request->password, $request->has('api_secret') ? $request->api_secret : null)) ->endpoint(session('MIGRATION_ENDPOINT')) ->start(); if ($authentication->isSuccessful()) { session()->put('MIGRATION_ACCOUNT_TOKEN', $authentication->getAccountToken()); + session()->put('MIGRAITON_API_SECRET', $authentication->getApiSecret()); return redirect( url('/migration/companies') diff --git a/app/Services/Migration/AuthService.php b/app/Services/Migration/AuthService.php index 7e1ec8bb2a..6ddd65bb11 100644 --- a/app/Services/Migration/AuthService.php +++ b/app/Services/Migration/AuthService.php @@ -1,5 +1,16 @@ username = $username; $this->password = $password; + $this->apiSecret = $apiSecret; } public function endpoint(string $endpoint) @@ -72,6 +87,10 @@ class AuthService return null; } + public function getApiSecret() + { + return $this->apiSecret; + } public function getErrors() { @@ -80,10 +99,16 @@ class AuthService private function getHeaders() { - return [ + $headers = [ 'X-Requested-With' => 'XMLHttpRequest', 'Content-Type' => 'application/json', ]; + + if (!is_null($this->apiSecret)) { + $headers['X-Api-Secret'] = $this->apiSecret; + } + + return $headers; } private function getUrl() diff --git a/app/Services/Migration/CompleteService.php b/app/Services/Migration/CompleteService.php index 3ebf406290..df774cdfed 100644 --- a/app/Services/Migration/CompleteService.php +++ b/app/Services/Migration/CompleteService.php @@ -87,11 +87,17 @@ class CompleteService private function getHeaders() { - return [ + $headers = [ 'X-Requested-With' => 'XMLHttpRequest', 'X-Api-Token' => $this->token, 'Content-Type' => 'multipart/form-data', ]; + + if (session('MIGRATION_API_SECRET')) { + $headers['X-Api-Secret'] = session('MIGRATION_API_SECRET'); + } + + return $headers; } private function getUrl() diff --git a/resources/lang/en/texts.php b/resources/lang/en/texts.php index c93cd24e96..939d876d40 100644 --- a/resources/lang/en/texts.php +++ b/resources/lang/en/texts.php @@ -3816,6 +3816,9 @@ $LANG = array( 'activity_65' => ':user emailed third reminder for invoice :invoice to :contact', 'activity_66' => ':user emailed endless reminder for invoice :invoice to :contact', 'expense_category_id' => 'Expense Category ID', + 'migration_auth_label' => 'Let\'s continue by authenticating.', + 'api_secret' => 'API secret', + 'migration_api_secret_notice' => 'You can find API_SECRET in the .env file or Invoice Ninja v5. If property is missing, leave field blank.', ); return $LANG; diff --git a/resources/views/migration/auth.blade.php b/resources/views/migration/auth.blade.php index 714da56fa2..b96404e08c 100644 --- a/resources/views/migration/auth.blade.php +++ b/resources/views/migration/auth.blade.php @@ -11,18 +11,25 @@

{!! trans('texts.welcome_to_the_new_version') !!}

-

Let's continue with authentication.


+

{!! trans('texts.migration_auth_label') !!}


{{ csrf_field() }} +
- +
- +
+ +
+ + + {!! trans('texts.migration_api_secret_notice') !!} +