Mirrors/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2024-11-10 13:12:50 +01:00
Code Issues Releases Activity

default value for sort input & fixes for strlen

Browse Source
This commit is contained in:
paulwer 2023-01-30 12:08:39 +01:00
parent ae5b9c0dd4
commit f27cca7f09
27 changed files with 34 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Filters/BankIntegrationFilters.php
View File

@ -91,7 +91,7 @@ class BankIntegrationFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/BankTransactionFilters.php
View File

@ -124,7 +124,7 @@ class BankTransactionFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/BankTransactionRuleFilters.php
View File

@ -62,7 +62,7 @@ class BankTransactionRuleFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

4
app/Filters/ClientFilters.php
View File

@ -60,7 +60,7 @@ class ClientFilters extends QueryFilters
{
$parts = explode(':', $balance);
if (! is_array($parts)) {
if (!is_array($sort_col) || count($sort_col) != 2) {
return $this->builder;
}
@ -139,7 +139,7 @@ class ClientFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/CompanyGatewayFilters.php
View File

@ -43,7 +43,7 @@ class CompanyGatewayFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/CreditFilters.php
View File

@ -100,7 +100,7 @@ class CreditFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/DesignFilters.php
View File

@ -44,7 +44,7 @@ class DesignFilters extends QueryFilters
*
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/ExpenseCategoryFilters.php
View File

@ -41,7 +41,7 @@ class ExpenseCategoryFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/ExpenseFilters.php
View File

@ -147,7 +147,7 @@ class ExpenseFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/PaymentFilters.php
View File

@ -77,7 +77,7 @@ class PaymentFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/PaymentTermFilters.php
View File

@ -42,7 +42,7 @@ class PaymentTermFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/ProductFilters.php
View File

@ -58,7 +58,7 @@ class ProductFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/ProjectFilters.php
View File

@ -53,7 +53,7 @@ class ProjectFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Illuminate\Eloquent\Query\Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/PurchaseOrderFilters.php
View File

@ -115,7 +115,7 @@ class PurchaseOrderFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/QuoteFilters.php
View File

@ -126,7 +126,7 @@ class QuoteFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/RecurringExpenseFilters.php
View File

@ -55,7 +55,7 @@ class RecurringExpenseFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/RecurringInvoiceFilters.php
View File

@ -98,7 +98,7 @@ class RecurringInvoiceFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/RecurringQuoteFilters.php
View File

@ -54,7 +54,7 @@ class RecurringQuoteFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Illuminate\Database\Eloquent\Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/SubscriptionFilters.php
View File

@ -42,7 +42,7 @@ class SubscriptionFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

10
app/Filters/SystemLogFilters.php
View File

@ -20,7 +20,7 @@ class SystemLogFilters extends QueryFilters
{
public function type_id(string $type_id = ''): Builder
{
if (strlen($type_id)) {
if (strlen($type_id) == 0) {
return $this->builder;
}
@ -29,7 +29,7 @@ class SystemLogFilters extends QueryFilters
public function category_id(string $category_id = ''): Builder
{
if (strlen($category_id)) {
if (strlen($category_id) == 0) {
return $this->builder;
}
@ -38,7 +38,7 @@ class SystemLogFilters extends QueryFilters
public function event_id(string $event_id = ''): Builder
{
if (strlen($event_id)) {
if (strlen($event_id) == 0) {
return $this->builder;
}
@ -54,7 +54,7 @@ class SystemLogFilters extends QueryFilters
*/
public function filter(string $filter = ''): Builder
{
if (strlen($filter)) {
if (strlen($filter) == 0) {
return $this->builder;
}
@ -67,7 +67,7 @@ class SystemLogFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/TaskFilters.php
View File

@ -97,7 +97,7 @@ class TaskFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/TaskStatusFilters.php
View File

@ -42,7 +42,7 @@ class TaskStatusFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/TaxRateFilters.php
View File

@ -42,7 +42,7 @@ class TaxRateFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/TokenFilters.php
View File

@ -42,7 +42,7 @@ class TokenFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

5
app/Filters/UserFilters.php
View File

@ -46,7 +46,7 @@ class UserFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);
@ -80,8 +80,9 @@ class UserFilters extends QueryFilters
public function with(string $value = ''): Builder
{
if(strlen($value) == 0)
if(strlen($value) == 0) {
return $this->builder;
}
return $this->builder
->orWhere($this->with_property, $value)

2
app/Filters/VendorFilters.php
View File

@ -61,7 +61,7 @@ class VendorFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);

2
app/Filters/WebhookFilters.php
View File

@ -42,7 +42,7 @@ class WebhookFilters extends QueryFilters
* @param string sort formatted as column|asc
* @return Builder
*/
public function sort(string $sort): Builder
public function sort(string $sort = ''): Builder
{
$sort_col = explode('|', $sort);