From 99b61247b08db85cbb306f5cd942fcd0e61ed01c Mon Sep 17 00:00:00 2001 From: stevenyomi <95685115+stevenyomi@users.noreply.github.com> Date: Mon, 15 Jan 2024 22:19:56 +0800 Subject: [PATCH] Update docs and checklist on web_hi_res icons (#275) --- .github/pull_request_template.md | 1 + CONTRIBUTING.md | 17 +++++++---------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5e2efbb8f..e0276c302 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,3 +7,4 @@ Checklist: - [ ] Have not changed source names - [ ] Have explicitly kept the `id` if a source's name or language were changed - [ ] Have tested the modifications by compiling and running the extension through Android Studio +- [ ] Have removed `web_hi_res_512.png` when adding a new extension diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b36272f82..8dd7a16cc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -209,9 +209,8 @@ src/// │   │   └── ic_launcher.png │   ├── mipmap-xxhdpi │   │   └── ic_launcher.png -│   ├── mipmap-xxxhdpi -│   │   └── ic_launcher.png -│   └── web_hi_res_512.png +│   └── mipmap-xxxhdpi +│      └── ic_launcher.png └── src └── eu └── kanade @@ -573,9 +572,8 @@ multisrc │   │   │   └── ic_launcher.png │   │   ├── mipmap-xxhdpi │   │   │   └── ic_launcher.png -│   │   ├── mipmap-xxxhdpi -│   │   │   └── ic_launcher.png -│   │   └── web_hi_res_512.png +│   │   └── mipmap-xxxhdpi +│   │      └── ic_launcher.png │   └── │   ├── additional.gradle │   ├── AndroidManifest.xml @@ -588,9 +586,8 @@ multisrc │   │   │   └── ic_launcher.png │   │   ├── mipmap-xxhdpi │   │   │   └── ic_launcher.png -│   │   ├── mipmap-xxxhdpi -│   │   │   └── ic_launcher.png -│   │   └── web_hi_res_512.png +│   │   └── mipmap-xxxhdpi +│   │      └── ic_launcher.png │   └── src │   └── .kt └── src @@ -857,7 +854,7 @@ Git Repository in Android Studio" section of the guide. > [!IMPORTANT] > Make sure you have generated the extension icon using the linked Icon Generator tool in the [Tools](#tools) > section. The icon **must follow the pattern** adopted by all other extensions: a square with rounded -> corners. +> corners. Make sure to remove the generated `web_hi_res_512.png`. Please **do test your changes by compiling it through Android Studio** before submitting it. Obvious untested PRs will not be merged, such as ones created with the GitHub web interface. Also make sure