1
0
mirror of https://github.com/mifi/lossless-cut.git synced 2024-11-24 03:12:41 +01:00

convert all non webvtt to webvtt in webm

closes #2179
This commit is contained in:
Mikael Finstad 2024-10-06 21:05:43 +02:00
parent 25f53e7f7e
commit 789f857e26
No known key found for this signature in database
GPG Key ID: 25AB36E3E81CBC26

View File

@ -126,8 +126,9 @@ function getPerStreamFlags({ stream, outputIndex, outFormat, manuallyCopyDisposi
// https://github.com/mifi/lossless-cut/issues/418
// https://www.reddit.com/r/PleX/comments/bcfvev/can_someone_eli5_subtitles/
addCodecArgs('srt');
} else if (outFormat === 'webm' && stream.codec_name === 'mov_text') {
} else if (outFormat === 'webm' && stream.codec_name !== 'webvtt') {
// Only WebVTT subtitles are supported for WebM.
// https://github.com/mifi/lossless-cut/issues/2179#issuecomment-2395413115
addCodecArgs('webvtt');
// eslint-disable-next-line unicorn/prefer-switch
} else if (outFormat === 'srt') { // not technically lossless but why not