Mirrors/lossless-cut
1
0
Fork 0
mirror of https://github.com/mifi/lossless-cut.git synced 2024-11-22 10:22:31 +01:00
Code Issues Releases Activity

restore previous scroll behavior

Browse Source 
fixes #1432
This commit is contained in:
Mikael Finstad 2023-01-27 15:02:49 +09:00
parent 3c079a02c5
commit cf789a9fb0
No known key found for this signature in database
GPG Key ID: 25AB36E3E81CBC26
1 changed files with 35 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
src/Timeline.jsx
View File

@ -189,27 +189,46 @@ const Timeline = memo(({
return (relX / target.offsetWidth) * durationSafe;
}, [durationSafe]);
const handleTap = useCallback((e) => {
if (e.nativeEvent.buttons === 1) { // primary button
seekAbs((getMouseTimelinePos(e.nativeEvent)));
}
}, [seekAbs, getMouseTimelinePos]);
const mouseDownRef = useRef();
const handleScrub = useCallback((e) => seekAbs((getMouseTimelinePos(e))), [seekAbs, getMouseTimelinePos]);
useEffect(() => {
setHoveringTime();
}, [playerTime, commandedTime]);
const onMouseMove = useCallback((e) => {
// eslint-disable-next-line no-bitwise
// const isButtonPressed = (index) => ((e.nativeEvent.buttons >> index) & 1);
if (e.nativeEvent.buttons === 0) { // no button pressed
setHoveringTime(getMouseTimelinePos(e.nativeEvent));
e.preventDefault();
} else if (e.nativeEvent.buttons === 1) { // primary button
handleTap(e);
e.preventDefault();
const onMouseDown = useCallback((e) => {
if (e.nativeEvent.buttons !== 1) return; // not primary button
handleScrub(e.nativeEvent);
mouseDownRef.current = e.target;
function onMouseMove(e2) {
if (mouseDownRef.current == null) return;
seekAbs(getMouseTimelinePos(e2));
}
}, [getMouseTimelinePos, handleTap]);
function onMouseUp() {
mouseDownRef.current = undefined;
window.removeEventListener('mouseup', onMouseUp);
window.removeEventListener('mousemove', onMouseMove);
}
// https://github.com/mifi/lossless-cut/issues/1432
// https://stackoverflow.com/questions/11533098/how-to-catch-mouse-up-event-outside-of-element
// https://stackoverflow.com/questions/6073505/what-is-the-difference-between-screenx-y-clientx-y-and-pagex-y
window.addEventListener('mouseup', onMouseUp, { once: true });
window.addEventListener('mousemove', onMouseMove);
}, [getMouseTimelinePos, handleScrub, seekAbs]);
const onMouseMove = useCallback((e) => {
if (!mouseDownRef.current) { // no button pressed
setHoveringTime(getMouseTimelinePos(e.nativeEvent));
}
e.preventDefault();
}, [getMouseTimelinePos]);
const onMouseOut = useCallback(() => setHoveringTime(), []);
const contextMenuTemplate = useMemo(() => [
@ -222,7 +241,7 @@ const Timeline = memo(({
// eslint-disable-next-line jsx-a11y/no-static-element-interactions,jsx-a11y/mouse-events-have-key-events
<div
style={{ position: 'relative' }}
onMouseDown={handleTap}
onMouseDown={onMouseDown}
onMouseMove={onMouseMove}
onMouseOut={onMouseOut}
>