Mirrors/openrw
1
0
Fork 0
mirror of https://github.com/rwengine/openrw.git synced 2024-10-06 09:07:19 +02:00
Code Issues Projects Releases Activity

cmake: detect clang-tidy using cmake module + add helper function

Browse Source
This commit is contained in:
Anonymous Maarten 2018-04-16 22:23:42 +02:00
parent c862da5ac1
commit 1e6f9a1edc
3 changed files with 96 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CMakeLists.txt
View File

@ -16,6 +16,10 @@ find_package(GLM REQUIRED)
find_package(FFmpeg REQUIRED)
find_package(SDL2 REQUIRED)
if(CHECK_CLANGTIDY)
find_package(ClangTidy REQUIRED)
endif()
# Include git hash in source
include(GetGitRevisionDescription)
get_git_head_revision(GIT_REFSPEC GIT_SHA1)

87
cmake/modules/FindClangTidy.cmake Normal file
View File

@ -0,0 +1,87 @@
# - Try to find clang-tidy executable and create clang_tidy_check_target function to check targets
# Once done this will define
#
# CLANG_TIDY_FOUND - system has clang-tidy
# CLANG_TIDY_BIN - path of clang-tidy
# CLANG_TIDY_VERSION - version of clang-tidy
#
# clang_tidy_check_target function:
# usage:
# clang_tidy_check_target(
# TARGET <target> # Target to attach clang-tidy to
# [FORMAT_STYLE <format_style>] # Format of clang-tidy output
# [FIX <fix_bool>] # Apply the clang-tidy fixes to the sources
# [CHECK_ALL] # run all clang-tidy checks
# )
# Copyright (c) 2018 OpenRW project
#
# Redistribution and use is allowed according to the terms of the New BSD license.
#
find_program(CLANG_TIDY_BIN
clang-tidy
)
if(CLANG_TIDY_BIN)
set(CLANG_TIDY_FOUND 1)
else()
set(CLANG_TIDY_FOUND 0)
endif()
if(CLANG_TIDY_BIN)
execute_process(
COMMAND "${CLANG_TIDY_BIN}" --version
OUTPUT_VARIABLE _CLANG_TIDY_VERSION_OUTPUT
)
string(REGEX MATCH "version ([0-9a-zA-Z\.]+)" _CLANG_TIDY_VERSION "${_CLANG_TIDY_VERSION_OUTPUT}")
if(_CLANG_TIDY_VERSION)
set(CLANG_TIDY_VERSION "${CMAKE_MATCH_1}")
else()
set(CLANG_TIDY_VERSION "unknown")
endif()
execute_process(
COMMAND "${CLANG_TIDY_BIN}" --help
OUTPUT_VARIABLE _CLANG_TIDY_HELP_OUTPUT
)
string(FIND "${_CLANG_TIDY_HELP_OUTPUT}" "-format-style" _CLANG_TIDY_FORMAT_STYLE_POS)
if(_CLANG_TIDY_FORMAT_STYLE_POS LESS 0)
set(CLANG_TIDY_FORMAT_STYLE_OPTION "-style=")
else()
set(CLANG_TIDY_FORMAT_STYLE_OPTION "-format-style=")
endif()
include(CMakeParseArguments)
function(clang_tidy_check_target)
cmake_parse_arguments(CTCT
"CHECK_ALL" #options
"TARGET;FORMAT_STYLE;FIX" #one_value_keywords
"" #multi_value_keywords
${ARGN}
)
set(CLANGTIDY_ARGS "${CLANG_TIDY_BIN}")
if(CTCT_CHECK_ALL)
list(APPEND CLANGTIDY_ARGS "-checks=*")
endif()
if(CTCT_FORMAT_STYLE)
list(APPEND CLANGTIDY_ARGS "${CLANG_TIDY_FORMAT_STYLE_OPTION}${CTCT_FORMAT_STYLE}")
endif()
if(CTCT_FIX)
list(APPEND CLANGTIDY_ARGS "-fix")
endif()
set_target_properties("${CTCT_TARGET}"
PROPERTIES
C_CLANG_TIDY "${CLANGTIDY_ARGS}"
CXX_CLANG_TIDY "${CLANGTIDY_ARGS}"
)
endfunction()
endif()
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(ClangTidy
REQUIRED_VARS CLANG_TIDY_BIN
VERSION_VAR CLANG_TIDY_VERSION
)
mark_as_advanced(CLANG_TIDY_BIN)

26
cmake_configure.cmake
View File

@ -129,23 +129,6 @@ if(CHECK_IWYU)
find_package(IncludeWhatYouUse REQUIRED)
endif()
if(CHECK_CLANGTIDY)
find_program(CLANGTIDY_PROGRAM
clang-tidy
)
if(NOT CLANGTIDY_PROGRAM)
message(FATAL_ERROR "Cannot find clang-tidy")
endif()
set(CLANGTIDY_ARGS "${CLANGTIDY_PROGRAM}")
list(APPEND CLANGTIDY_ARGS
"-style=file"
"-checks=*"
)
if(CHECK_CLANGTIDY_FIX)
list(APPEND CLANGTIDY_ARGS "-fix")
endif()
endif()
function(openrw_target_apply_options)
set(IWYU_MAPPING "${PROJECT_SOURCE_DIR}/openrw_iwyu.imp")
cmake_parse_arguments("OPENRW_APPLY" "" "TARGET" "" ${ARGN})
@ -157,10 +140,11 @@ function(openrw_target_apply_options)
endif()
if(CHECK_CLANGTIDY)
set_target_properties("${OPENRW_APPLY_TARGET}"
PROPERTIES
C_CLANG_TIDY "${CLANGTIDY_ARGS}"
CXX_CLANG_TIDY "${CLANGTIDY_ARGS}"
clang_tidy_check_target(
TARGET "${OPENRW_APPLY_TARGET}"
FORMAT_STYLE "file"
FIX "${CHECK_CLANGTIDY_FIX}"
CHECK_ALL
)
endif()
endfunction()