1
0
mirror of https://github.com/rwengine/openrw.git synced 2024-11-25 20:02:40 +01:00

Merge pull request #484 from husho/fixcrash

Fixed crash on new game, fixed missions not failing on death/arrest
This commit is contained in:
Daniel Evans 2018-05-22 01:06:01 +01:00 committed by GitHub
commit 5f85de5bd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -12,14 +12,17 @@
#include "script/ScriptModule.hpp"
void ScriptMachine::executeThread(SCMThread& t, int msPassed) {
// @todo Add support for multiple players
PlayerController* player = getState()->world->players.at(0);
if (t.isMission
&& t.deathOrArrestCheck
&& (player->isWasted() || player->isBusted())) {
t.wastedOrBusted = true;
t.stackDepth = 0;
t.programCounter = t.calls[t.stackDepth];
auto& players = getState()->world->players;
if (!players.empty()) {
// @todo Add support for multiple players
PlayerController* player = players.at(0);
if (t.isMission && t.deathOrArrestCheck &&
(player->isWasted() || player->isBusted())) {
t.wastedOrBusted = true;
t.stackDepth = 0;
t.programCounter = t.calls[t.stackDepth];
}
}
if (t.wakeCounter > 0) {
@ -180,7 +183,11 @@ void ScriptMachine::executeThread(SCMThread& t, int msPassed) {
ScriptMachine::ScriptMachine(GameState* _state, SCMFile* file,
ScriptModule* ops)
: file(file), module(ops), state(_state), debugFlag(false), randomNumberGen(std::random_device()()) {
: file(file)
, module(ops)
, state(_state)
, debugFlag(false)
, randomNumberGen(std::random_device()()) {
// Copy globals
auto size = file->getGlobalsSize();
globalData.resize(size);
@ -204,7 +211,7 @@ void ScriptMachine::startThread(SCMThread::pc_t start, bool mission) {
t.isMission = mission;
t.finished = false;
t.stackDepth = 0;
t.deathOrArrestCheck = false;
t.deathOrArrestCheck = true;
t.wastedOrBusted = false;
_activeThreads.push_back(t);
}