From 015e31b57753e7ae9c465e739d6ab81bf7e48be0 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Wed, 26 Sep 2018 07:20:54 -0400 Subject: [PATCH] fix https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=909626 --- platform/webext/manifest.json | 3 ++- tools/make-webext-meta.py | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/platform/webext/manifest.json b/platform/webext/manifest.json index 6390720f4..019ea79ef 100644 --- a/platform/webext/manifest.json +++ b/platform/webext/manifest.json @@ -93,7 +93,8 @@ "default_icon": { "16": "img/ublock.svg", "48": "img/ublock.svg" - } + }, + "open_at_install": false }, "storage": { "managed_schema": "managed_storage.json" diff --git a/tools/make-webext-meta.py b/tools/make-webext-meta.py index b9c7e3551..8639d2b37 100644 --- a/tools/make-webext-meta.py +++ b/tools/make-webext-meta.py @@ -27,6 +27,12 @@ if match: webext_manifest['name'] += ' development build' webext_manifest['short_name'] += ' dev build' webext_manifest['browser_action']['default_title'] += ' dev build' +else: + # https://bugzilla.mozilla.org/show_bug.cgi?id=1459007 + # By design Firefox opens the sidebar with new installation of + # uBO when sidebar_action is present in the manifest. + # Remove sidebarAction support for stable release of uBO. + del webext_manifest['sidebar_action'] with open(webext_manifest_file, mode='w', encoding='utf-8') as f2: json.dump(webext_manifest, f2, indent=2, separators=(',', ': '), sort_keys=True)