1
0
mirror of https://github.com/gorhill/uBlock.git synced 2024-07-08 12:57:57 +02:00

Eliminate case-sensitivity from values in set-cookie scriptlet

Related discussion:
- https://github.com/uBlockOrigin/uAssets/discussions/18762#discussioncomment-6338716

Additionally, add `allow` as valid value.
This commit is contained in:
Raymond Hill 2023-07-20 07:53:14 -04:00
parent 9d20cbe6af
commit 03d0d8d4ce
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2

View File

@ -784,7 +784,7 @@ function setLocalStorageItemCore(
value = `${Date()}`; value = `${Date()}`;
} }
} else { } else {
if ( trustedValues.includes(value) === false ) { if ( trustedValues.includes(value.toLowerCase()) === false ) {
if ( /^\d+$/.test(value) === false ) { return; } if ( /^\d+$/.test(value) === false ) { return; }
value = parseInt(value, 10); value = parseInt(value, 10);
if ( value > 32767 ) { return; } if ( value > 32767 ) { return; }
@ -2896,15 +2896,14 @@ function setCookie(
if ( name === '' ) { return; } if ( name === '' ) { return; }
name = encodeURIComponent(name); name = encodeURIComponent(name);
const validValues = new Set([ const validValues = [
'true', 'True', 'true', 'false',
'false', 'False', 'yes', 'y', 'no', 'n',
'yes', 'Yes', 'y', 'Y', 'ok',
'no', 'No', 'n', 'N', 'accept', 'reject',
'ok', 'OK', 'allow',
'Accept', 'Reject', ];
]); if ( validValues.includes(value.toLowerCase()) === false ) {
if ( validValues.has(value) === false ) {
if ( /^\d+$/.test(value) === false ) { return; } if ( /^\d+$/.test(value) === false ) { return; }
const n = parseInt(value, 10); const n = parseInt(value, 10);
if ( n > 15 ) { return; } if ( n > 15 ) { return; }