From 0414ce80a09887f7ccd6248c2b5a6f922dd2cd27 Mon Sep 17 00:00:00 2001
From: Raymond Hill <rhill@raymondhill.net>
Date: Mon, 26 Feb 2018 16:52:16 -0500
Subject: [PATCH] code review for #3428

---
 src/js/logger-ui.js | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/js/logger-ui.js b/src/js/logger-ui.js
index a25eef3b3..c98de8632 100644
--- a/src/js/logger-ui.js
+++ b/src/js/logger-ui.js
@@ -48,7 +48,9 @@ var removeAllChildren = logger.removeAllChildren = function(node) {
 
 var tabIdFromClassName = function(className) {
     var matches = className.match(/\btab_([^ ]+)\b/);
-    return matches !== null ? matches[1] : '';
+    if ( matches === null ) { return 0; }
+    if ( matches[1] === 'bts' ) { return -1; }
+    return parseInt(matches[1], 10);
 };
 
 var tabIdFromPageSelector = logger.tabIdFromPageSelector = function() {
@@ -1609,12 +1611,7 @@ var popupManager = (function() {
     var toggleOn = function(td) {
         var tr = td.parentNode;
         realTabId = localTabId = tabIdFromClassName(tr.className);
-        if ( realTabId === '' ) {
-            return;
-        }
-        if ( localTabId === 'bts' ) {
-            realTabId = -1;
-        }
+        if ( realTabId === 0 ) { return; }
 
         container = uDom.nodeFromId('popupContainer');