Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-24 11:22:44 +01:00
Code Issues Releases Wiki Activity

this fixes #399

Browse Source
This commit is contained in:
Raymond Hill 2014-12-06 15:00:31 -02:00
parent 665c05c0a3
commit 0501c0712a
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/js/contentscript-end.js
View File

@ -501,11 +501,9 @@ var messager = vAPI.messaging.channel('contentscript-end.js');
// If `!important` is not there, going back using history will // If `!important` is not there, going back using history will
// likely cause the hidden element to re-appear. // likely cause the hidden element to re-appear.
if ( details.collapse ) { if ( details.collapse ) {
if ( target.parentNode ) { // https://github.com/gorhill/uBlock/issues/399
target.parentNode.removeChild(target); // Never remove elements from the DOM, just hide them
} else { target.style.setProperty('display', 'none', 'important');
target.style.setProperty('display', 'none', 'important');
}
} else { } else {
target.style.setProperty('visibility', 'hidden', 'important'); target.style.setProperty('visibility', 'hidden', 'important');
} }
@ -570,11 +568,9 @@ var messager = vAPI.messaging.channel('contentscript-end.js');
request = requests[i]; request = requests[i];
elem = elements[request.index]; elem = elements[request.index];
if ( collapse ) { if ( collapse ) {
if ( elem.parentNode ) { // https://github.com/gorhill/uBlock/issues/399
elem.parentNode.removeChild(elem); // Never remove elements from the DOM, just hide them
} else { elem.style.setProperty('display', 'none', 'important');
elem.style.setProperty('display', 'none', 'important');
}
} else { } else {
elem.style.setProperty('visibility', 'hidden', 'important'); elem.style.setProperty('visibility', 'hidden', 'important');
} }