From 0870aea2eb62da57c77a3d326a5bffe18dba393e Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 13 Sep 2016 11:56:13 -0400 Subject: [PATCH] code review re. #1735 --- src/js/tab.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/js/tab.js b/src/js/tab.js index 550f0cf10..6ca1c7818 100644 --- a/src/js/tab.js +++ b/src/js/tab.js @@ -392,15 +392,14 @@ housekeep itself. }; // https://github.com/gorhill/uBlock/issues/1735 - // Always push before committing, to allow popup detector code to do its - // job. + // Filter for popups if actually committing. var commit = function(tabId, url) { var entry = tabContexts[tabId]; if ( entry === undefined ) { entry = push(tabId, url); } else { - entry.push(url); entry.commit(url); + popupCandidateTest(tabId); } return entry; };