From 0e11d6e95ea83d48e23422f62cc8799fb6a61330 Mon Sep 17 00:00:00 2001
From: gorhill <rhill@raymondhill.net>
Date: Tue, 24 Jan 2017 13:53:04 -0500
Subject: [PATCH] code review: fix rtl rendering of 3rd-party filters pane

---
 src/3p-filters.html    | 18 +++++++++---------
 src/css/3p-filters.css |  8 ++++----
 src/js/3p-filters.js   |  2 +-
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/3p-filters.html b/src/3p-filters.html
index 823dfff7e..64931d569 100644
--- a/src/3p-filters.html
+++ b/src/3p-filters.html
@@ -43,15 +43,15 @@
             </li>
         <li class="listEntry">
             <input type="checkbox"><!--
-         --><a class="content" type="text/plain" target="_blank" href=""></a><!--
-         --><a class="fa support" href="" target="_blank">&#xf015;</a><!--
-         --><a class="fa remove" href="">&#xf00d;</a><!--
-         --><a class="fa mustread" href="" target="_blank">&#xf05a;</a><!--
-         --><span class="fa status unsecure" title="http">&#xf13e;</span><!--
-         --><span class="counts dim"></span><!--
-         --><span class="fa status obsolete" title="3pExternalListObsolete">&#xf071;</span><!--
-         --><span class="fa status cache">&#xf017;</span><!--
-         --><span class="fa status updating">&#xf110;</span><!--
+         --><a class="content" type="text/plain" target="_blank" href=""></a>&#8203;<!--
+         --><a class="fa support" href="" target="_blank">&#xf015;</a>&#8203;<!--
+         --><a class="fa remove" href="">&#xf00d;</a>&#8203;<!--
+         --><a class="fa mustread" href="" target="_blank">&#xf05a;</a>&#8203;<!--
+         --><span class="fa status unsecure" title="http">&#xf13e;</span>&#8203;<!--
+         --><span class="counts dim"></span>&#8203;<!--
+         --><span class="fa status obsolete" title="3pExternalListObsolete">&#xf071;</span>&#8203;<!--
+         --><span class="fa status cache">&#xf017;</span>&#8203;<!--
+         --><span class="fa status updating">&#xf110;</span>&#8203;<!--
          --><span class="fa status failed">&#xf06a;</span>
             </li>
         </ul>
diff --git a/src/css/3p-filters.css b/src/css/3p-filters.css
index a5052ca45..359ab709e 100644
--- a/src/css/3p-filters.css
+++ b/src/css/3p-filters.css
@@ -23,7 +23,7 @@ body.hideUnused #listsOfBlockedHostsPrompt:before {
     padding-left: 0.5em;
     padding-right: 0em;
     }
-body[dir=rtl] #lists {
+body[dir="rtl"] #lists {
     padding-left: 0em;
     padding-right: 0.5em;
     }
@@ -57,12 +57,12 @@ li.listEntry {
     line-height: 150%;
     margin: 0 auto 0 auto;
     margin-left: 2.5em;
-    margin-right: 0em;
+    margin-right: 0;
     text-indent: -2em;
     }
-body[dir=rtl] li.listEntry {
+body[dir="rtl"] li.listEntry {
     margin-left: 0em;
-    margin-right: 1em;
+    margin-right: 2.5em;
     }
 li.listEntry > * {
     margin-right: 0.5em;
diff --git a/src/js/3p-filters.js b/src/js/3p-filters.js
index f43cb8bd3..57cccf2f6 100644
--- a/src/js/3p-filters.js
+++ b/src/js/3p-filters.js
@@ -91,7 +91,7 @@ var renderFilterLists = function(soft) {
             elem = li.querySelector('a:nth-of-type(1)');
             elem.setAttribute('href', 'asset-viewer.html?url=' + encodeURI(listKey));
             elem.setAttribute('type', 'text/html');
-            elem.textContent = listNameFromListKey(listKey) + '\u200E';
+            elem.textContent = listNameFromListKey(listKey);
             li.classList.remove('toRemove');
             if ( entry.supportName ) {
                 li.classList.add('support');