From 13969ed9373da5d20da680302b9174657c388284 Mon Sep 17 00:00:00 2001 From: gorhill Date: Sat, 19 Dec 2015 17:58:26 -0500 Subject: [PATCH] minor code review --- src/js/contentscript-end.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/js/contentscript-end.js b/src/js/contentscript-end.js index e2993b607..809bf9baf 100644 --- a/src/js/contentscript-end.js +++ b/src/js/contentscript-end.js @@ -814,8 +814,10 @@ var uBlockCollapser = (function() { // effect on the document), and thus must be logged if needed. var addedNodesHandler = function() { addedNodeListsTimer = null; - var nodeList, iNode, node; - while ( (nodeList = addedNodeLists.pop()) ) { + var iNodeList = addedNodeLists.length, + nodeList, iNode, node; + while ( iNodeList-- ) { + nodeList = addedNodeLists[iNodeList]; iNode = nodeList.length; while ( iNode-- ) { node = nodeList[iNode]; @@ -829,6 +831,7 @@ var uBlockCollapser = (function() { collapser.iframesFromNode(node); } } + addedNodeLists.length = 0; if ( contextNodes.length !== 0 ) { idsFromNodeList(selectNodes('[id]')); classesFromNodeList(selectNodes('[class]'));