From 1ffdb7d948572cff86055325cd5ae412660d1a2b Mon Sep 17 00:00:00 2001
From: Raymond Hill <rhill@raymondhill.net>
Date: Tue, 25 Apr 2023 21:15:11 -0400
Subject: [PATCH] Various minor code review

---
 platform/common/vapi-background.js |  2 +-
 src/js/lz4.js                      |  2 +-
 src/js/storage.js                  | 11 +++++------
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/platform/common/vapi-background.js b/platform/common/vapi-background.js
index ca090b85f..8106bbefd 100644
--- a/platform/common/vapi-background.js
+++ b/platform/common/vapi-background.js
@@ -143,7 +143,7 @@ vAPI.alarms = {
             const delayInMinutes = this.normalizeDelay(delay);
             browser.alarms.get(this.name, alarm => {
                 if ( alarm ) { return; }
-                return browser.alarms.create(this.name, { delayInMinutes });
+                browser.alarms.create(this.name, { delayInMinutes });
             });
         }
         offon(delay) {
diff --git a/src/js/lz4.js b/src/js/lz4.js
index 51021d16d..3c5bf3800 100644
--- a/src/js/lz4.js
+++ b/src/js/lz4.js
@@ -91,7 +91,7 @@ const ttlManage = function(count) {
     ttlTimer.off();
     ttlCount += count;
     if ( ttlCount > 0 ) { return; }
-    if ( lz4CodecInstance === null ) { return; }
+    if ( lz4CodecInstance === undefined ) { return; }
     ttlTimer.on(ttlDelay);
 };
 
diff --git a/src/js/storage.js b/src/js/storage.js
index 6fcd53e3e..c267d612e 100644
--- a/src/js/storage.js
+++ b/src/js/storage.js
@@ -1211,6 +1211,7 @@ self.addEventListener('hiddenSettingsChanged', ( ) => {
 
     const create = async function() {
         if ( µb.inMemoryFilters.length !== 0 ) { return; }
+        if ( Object.keys(µb.availableFilterLists).length === 0 ) { return; }
         await Promise.all([
             io.put(
                 'selfie/main',
@@ -1245,12 +1246,10 @@ self.addEventListener('hiddenSettingsChanged', ( ) => {
             selfie = JSON.parse(details.content);
         } catch(ex) {
         }
-        if (
-            selfie instanceof Object === false ||
-            selfie.magic !== µb.systemSettings.selfieMagic
-        ) {
-            return false;
-        }
+        if ( selfie instanceof Object === false ) { return false; }
+        if ( selfie.magic !== µb.systemSettings.selfieMagic ) { return false; }
+        if ( selfie.availableFilterLists instanceof Object === false ) { return false; }
+        if ( Object.keys(selfie.availableFilterLists).length === 0 ) { return false; }
         µb.availableFilterLists = selfie.availableFilterLists;
         return true;
     };