From 211b2813359b73906478c766164c320c1e2b762b Mon Sep 17 00:00:00 2001 From: gorhill Date: Thu, 31 Jul 2014 00:17:18 -0400 Subject: [PATCH] this fixes #121 --- js/abp-filters.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/js/abp-filters.js b/js/abp-filters.js index e0f47451e..694b0d4e4 100644 --- a/js/abp-filters.js +++ b/js/abp-filters.js @@ -847,9 +847,11 @@ FilterParser.prototype.parseOptType = function(raw, not) { var type = this.toNormalizedType[raw]; if ( not ) { for ( var k in typeNameToTypeValue ) { - if ( k === type ) { - continue; - } + if ( k === type ) { continue; } + // https://github.com/gorhill/uBlock/issues/121 + // `popup` is a special type, it cannot be set for filter intended + // for real net request types + if ( k === 'popup' ) { continue; } this.types.push(typeNameToTypeValue[k]); } } else {