From 2378a63cf0b10ec51da8df332bc56a750602683b Mon Sep 17 00:00:00 2001 From: gorhill Date: Fri, 6 Feb 2015 18:20:33 -0500 Subject: [PATCH] re. #704: forgot localized string --- src/_locales/en/messages.json | 4 ++++ src/js/popup.js | 8 ++++---- src/popup.html | 4 ++-- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json index 94edc24f4..fcf20f3c8 100644 --- a/src/_locales/en/messages.json +++ b/src/_locales/en/messages.json @@ -180,6 +180,10 @@ "description":"" }, "popupHitDomainCountPrompt":{ + "message":"domains touched", + "description":"appears in popup" + }, + "popupHitDomainCount":{ "message":"{{count}} out of {{total}}", "description":"appears in popup" }, diff --git a/src/js/popup.js b/src/js/popup.js index e83c070fc..ed864b79e 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -50,7 +50,7 @@ var touchedDomainCount = 0; var rowsToRecycle = uDom(); var cachedPopupHash = ''; var orStr = vAPI.i18n('popupOr'); -var domainsHitStr = vAPI.i18n('popupHitDomainCountPrompt'); +var domainsHitStr = vAPI.i18n('popupHitDomainCount'); /******************************************************************************/ @@ -302,7 +302,7 @@ var renderPrivacyExposure = function() { var summary = domainsHitStr.replace('{{count}}', touchedDomainCount.toLocaleString()) .replace('{{total}}', allDomainCount.toLocaleString()); - uDom('#privacyExposure').text(summary); + uDom('#popupHitDomainCount').text(summary); }; /******************************************************************************/ @@ -330,7 +330,7 @@ var renderPopup = function() { var total = popupData.pageAllowedRequestCount + blocked; var text = []; if ( total === 0 ) { - text.push('0'); + text.push(formatNumber(0)); } else { text.push( formatNumber(blocked), @@ -344,7 +344,7 @@ var renderPopup = function() { total = popupData.globalAllowedRequestCount + blocked; text = []; if ( total === 0 ) { - text.push('0'); + text.push(formatNumber(0)); } else { text.push( formatNumber(blocked), diff --git a/src/popup.html b/src/popup.html index 3d08a00f4..07a39d4b5 100644 --- a/src/popup.html +++ b/src/popup.html @@ -23,8 +23,8 @@

?

?

-

domains touched

-

+

+