From 28fbda660757961189b8bff25144dc45e2685b0f Mon Sep 17 00:00:00 2001
From: gorhill <rhill@raymondhill.net>
Date: Sun, 26 Apr 2015 20:33:49 -0400
Subject: [PATCH] code review re. #134

---
 src/js/static-net-filtering.js | 5 ++---
 src/js/storage.js              | 9 +--------
 2 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/src/js/static-net-filtering.js b/src/js/static-net-filtering.js
index 53552dc9c..f8d521115 100644
--- a/src/js/static-net-filtering.js
+++ b/src/js/static-net-filtering.js
@@ -910,10 +910,9 @@ FilterHostnameDict.prototype.freeze = function() {
     var bucket;
     for ( var key in buckets ) {
         bucket = buckets[key];
-        if ( typeof bucket !== 'object' ) {
-            continue;
+        if ( typeof bucket === 'object' ) {
+            buckets[key] = this.freezeBucket(bucket);
         }
-        buckets[key] = this.freezeBucket(bucket);
     }
 };
 
diff --git a/src/js/storage.js b/src/js/storage.js
index 5a4652625..3823b2285 100644
--- a/src/js/storage.js
+++ b/src/js/storage.js
@@ -159,7 +159,7 @@
 
     var µb = this;
 
-    var onCompiledListLoaded = function() {
+    var onSaved = function() {
         var compiledFilters = µb.compileFilters(filters);
         var snfe = µb.staticNetFilteringEngine;
         var cfe = µb.cosmeticFilteringEngine;
@@ -176,13 +176,6 @@
         µb.cosmeticFilteringEngine.freeze();
     };
 
-    var onSaved = function(details) {
-        if ( details.error ) {
-            return;
-        }
-        µb.getCompiledFilterList(µb.userFiltersPath, onCompiledListLoaded);
-    };
-
     var onLoaded = function(details) {
         if ( details.error ) {
             return;