From 44753053c3fd732cccb321e5e64489ceb1d954cd Mon Sep 17 00:00:00 2001
From: Raymond Hill <rhill@raymondhill.net>
Date: Sat, 19 Nov 2022 12:29:10 -0500
Subject: [PATCH] Prevent the creation of non-cosmetic extended filters in
 element picker

Related issue:
- https://github.com/uBlockOrigin/uBlock-issues/issues/2232
---
 src/js/epicker-ui.js | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/js/epicker-ui.js b/src/js/epicker-ui.js
index 9169efe56..fec76ccc0 100644
--- a/src/js/epicker-ui.js
+++ b/src/js/epicker-ui.js
@@ -113,11 +113,10 @@ const filterFromTextarea = function() {
     const sfp = staticFilteringParser;
     sfp.analyze(filter);
     sfp.analyzeExtra();
-    if (
-        sfp.category !== sfp.CATStaticExtFilter &&
-        sfp.category !== sfp.CATStaticNetFilter ||
-        sfp.shouldDiscard()
-    ) {
+    if ( sfp.shouldDiscard() ) { return '!'; }
+    if ( sfp.category === sfp.CATStaticExtFilter ) {
+        if ( sfp.hasFlavor(sfp.BITFlavorExtCosmetic) === false ) { return '!'; }
+    } else if ( sfp.category !== sfp.CATStaticNetFilter ) {
         return '!';
     }
     return filter;