From 4d3a2b5f85354ce4a390681534f2ff7e90eaae54 Mon Sep 17 00:00:00 2001
From: anvakl <34994045+anvakl@users.noreply.github.com>
Date: Tue, 24 Apr 2018 15:35:30 +0530
Subject: [PATCH] Minor fixes to code (#3720)

* Fix leftovers from old code.

* change changes.procedural.size to changes.procedural.length

changes.procedural is an array so it should be changes.procedural.length
the  code works with changes.procedural.size because (undefined !== 0) is always true.
---
 platform/firefox/vapi-client.js      | 4 ++--
 src/js/scriptlets/cosmetic-logger.js | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/platform/firefox/vapi-client.js b/platform/firefox/vapi-client.js
index aeb83cd19..4cf5e4e6a 100644
--- a/platform/firefox/vapi-client.js
+++ b/platform/firefox/vapi-client.js
@@ -296,7 +296,7 @@ vAPI.messaging = {
         // the main process is no longer reachable: memory leaks and bad
         // performance become a risk -- especially for long-lived, dynamic
         // pages. Guard against this.
-        if ( this.pendingCount > 25 ) {
+        if ( this.pending.size > 25 ) {
             vAPI.shutdown.exec();
         }
         this.connect();
@@ -340,7 +340,7 @@ vAPI.messaging = {
     removeChannelListener: function(channelName, listener) {
         var listeners = this.channels.get(channelName);
         if ( listeners === undefined ) { return; }
-        var pos = this.listeners.indexOf(listener);
+        var pos = listeners.indexOf(listener);
         if ( pos === -1 ) { return; }
         listeners.splice(pos, 1);
         if ( listeners.length === 0 ) {
diff --git a/src/js/scriptlets/cosmetic-logger.js b/src/js/scriptlets/cosmetic-logger.js
index bbfafa43e..a1ea4faa5 100644
--- a/src/js/scriptlets/cosmetic-logger.js
+++ b/src/js/scriptlets/cosmetic-logger.js
@@ -197,7 +197,7 @@ var handlers = {
             for ( selector of changes.procedural ) {
                 procedural.dict.set(selector.raw, selector);
             }
-            if ( changes.procedural.size !== 0 ) {
+            if ( changes.procedural.length !== 0 ) {
                 jobQueue.push(ProceduralJob.create());
             }
         }