From 57a7f6bcd7f9038047a25a157a7470e34ef38d11 Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 25 Aug 2015 11:21:35 -0400 Subject: [PATCH] code review last commit re. #602 External filter lists are not meant to appear in checksums.txt. --- src/js/assets.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/js/assets.js b/src/js/assets.js index 572706f18..6b531281e 100644 --- a/src/js/assets.js +++ b/src/js/assets.js @@ -433,7 +433,7 @@ var getRepoMetadata = function(callback) { return ''; } // https://github.com/gorhill/uBlock/issues/602 - // Need to convert old asset entries to new asset entries. + // External filter lists are not meant to appear in checksums.txt. // TODO: remove this code once v1.1.0.0 is everywhere. var out = []; var listMap = µBlock.oldListToNewListMap; @@ -446,10 +446,9 @@ var getRepoMetadata = function(callback) { continue; } if ( listMap.hasOwnProperty(matches[2]) ) { - out.push(matches[1] + ' ' + listMap[matches[2]]); - } else { - out.push(line); + continue; } + out.push(line); } return out.join('\n'); };