Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-11-07 03:12:33 +01:00
Code Issues Releases Wiki Activity

Fix an issue in new logger export feature

Browse Source 
Specifically, if selecting table+markdown, the export dialog
would no longer be accessible once closed.
This commit is contained in:
Raymond Hill 2019-01-14 16:52:13 -05:00
parent 093734a555
commit 5d5b05b387
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/js/logger-ui.js
View File

@ -1503,7 +1503,11 @@ const reloadTab = function(ev) {
// Rule // Rule
if ( if (
(text !== '') && (text !== '') &&
(trcl.contains('dynamicHost') || trcl.contains('dynamicUrl')) (
trcl.contains('dynamicHost') ||
trcl.contains('dynamicUrl') ||
trcl.contains('switch')
)
) { ) {
rows[2].children[1].textContent = text; rows[2].children[1].textContent = text;
} else { } else {
@ -2333,10 +2337,12 @@ const popupManager = (function() {
} }
outputAll.push(outputOne.join('|')); outputAll.push(outputOne.join('|'));
} }
outputAll.unshift( if ( fieldCount !== 0 ) {
`${' |'.repeat(fieldCount-1)} `, outputAll.unshift(
`${':--- |'.repeat(fieldCount-1)}:--- ` `${' |'.repeat(fieldCount-1)} `,
); `${':--- |'.repeat(fieldCount-1)}:--- `
);
}
return `<details><summary>Logger output</summary>\n\n|${outputAll.join('|\n|')}|\n</details>\n`; return `<details><summary>Logger output</summary>\n\n|${outputAll.join('|\n|')}|\n</details>\n`;
}; };
@ -2392,7 +2398,6 @@ const popupManager = (function() {
); );
} }
options[group] = value; options[group] = value;
format();
}; };
const onOption = function(ev) { const onOption = function(ev) {
@ -2421,6 +2426,7 @@ const popupManager = (function() {
group.getAttribute('data-radio'), group.getAttribute('data-radio'),
item.getAttribute('data-radio-item') item.getAttribute('data-radio-item')
); );
format();
ev.stopPropagation(); ev.stopPropagation();
}; };
@ -2432,18 +2438,19 @@ const popupManager = (function() {
lines.length = 0; lines.length = 0;
} }
); );
setRadioButton('format', options.format); setRadioButton('format', options.format);
setRadioButton('encoding', options.encoding); setRadioButton('encoding', options.encoding);
collectLines();
format();
dialog.querySelector('.options').addEventListener( dialog.querySelector('.options').addEventListener(
'click', 'click',
onOption, onOption,
{ capture: true } { capture: true }
); );
collectLines();
format();
modalDialog.show(); modalDialog.show();
}; };