From 5e1f4d7906c9e18d9d3c45cc4c265b02f2cfddf1 Mon Sep 17 00:00:00 2001
From: Raymond Hill <rhill@raymondhill.net>
Date: Fri, 9 Aug 2019 09:31:20 -0400
Subject: [PATCH] Invalidate browser's memory cache after using element picker

Related reports:
- https://www.reddit.com/r/uBlockOrigin/comments/cj7g7m/
- https://www.reddit.com/r/uBlockOrigin/comments/cnq0bi/

The browser cache will be invalidated only when creating
static network filter through the element picker.

As per @gwarser's arguments in favor of implementing
usage of webRequest.handlerBehaviorChanged():
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/handlerBehaviorChanged
---
 src/js/scriptlets/element-picker.js | 9 +++++----
 src/js/storage.js                   | 6 ++++++
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/js/scriptlets/element-picker.js b/src/js/scriptlets/element-picker.js
index 5e6325c66..8f417aa2f 100644
--- a/src/js/scriptlets/element-picker.js
+++ b/src/js/scriptlets/element-picker.js
@@ -1040,7 +1040,7 @@ const userFilterFromCandidate = function(callback) {
 
         // Cosmetic filter?
         if ( v.startsWith('##') ) {
-            callback(hostname + v);
+            callback(hostname + v, true);
             return;
         }
 
@@ -1188,8 +1188,8 @@ const onDialogClicked = function(ev) {
         // We have to exit from preview mode: this guarantees matching elements
         // will be found for the candidate filter.
         filterToDOMInterface.preview(false);
-        userFilterFromCandidate(filter => {
-            if ( !filter ) { return; }
+        userFilterFromCandidate((filter = undefined, isCosmetic = false) => {
+            if ( filter === undefined ) { return; }
             vAPI.messaging.send(
                 'elementPicker',
                 {
@@ -1197,7 +1197,8 @@ const onDialogClicked = function(ev) {
                     autoComment: true,
                     filters: filter,
                     origin: window.location.origin,
-                    pageDomain: window.location.hostname
+                    pageDomain: window.location.hostname,
+                    killCache: isCosmetic === false,
                 }
             );
             filterToDOMInterface.preview(rawFilterFromTextarea(), true);
diff --git a/src/js/storage.js b/src/js/storage.js
index 73a7b5851..51861aec9 100644
--- a/src/js/storage.js
+++ b/src/js/storage.js
@@ -468,6 +468,12 @@
         this.redirectEngine.freeze();
         this.staticExtFilteringEngine.freeze();
         this.selfieManager.destroy();
+
+        // https://www.reddit.com/r/uBlockOrigin/comments/cj7g7m/
+        // https://www.reddit.com/r/uBlockOrigin/comments/cnq0bi/
+        if ( options.killCache ) {
+            browser.webRequest.handlerBehaviorChanged();
+        }
     };
 
     const onLoaded = details => {