From 6c8b2a1b610255c00f6151ceb63803e2edbb5e70 Mon Sep 17 00:00:00 2001 From: AlexVallat Date: Tue, 31 Mar 2015 12:03:35 +0100 Subject: [PATCH] Changes following review --- platform/firefox/frameModule.js | 2 +- platform/firefox/vapi-background.js | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/platform/firefox/frameModule.js b/platform/firefox/frameModule.js index a1de19ad9..aab44730b 100644 --- a/platform/firefox/frameModule.js +++ b/platform/firefox/frameModule.js @@ -323,7 +323,7 @@ const LocationChangeListener = function(docShell) { this.docShell.addProgressListener(this, Ci.nsIWebProgress.NOTIFY_LOCATION); } } -} +}; LocationChangeListener.prototype.QueryInterface = XPCOMUtils.generateQI(["nsIWebProgressListener", "nsISupportsWeakReference"]); diff --git a/platform/firefox/vapi-background.js b/platform/firefox/vapi-background.js index faaf1a549..58f3d4cc1 100644 --- a/platform/firefox/vapi-background.js +++ b/platform/firefox/vapi-background.js @@ -328,7 +328,6 @@ var tabWatcher = { onTabSelect: function({target}) { vAPI.setIcon(vAPI.tabs.getTabId(target), getOwnerWindow(target)); - return; }, }; @@ -408,7 +407,6 @@ vAPI.tabs.registerListeners = function() { tabContainer = tabBrowser.deck; } else if ( tabBrowser.tabContainer ) { tabContainer = tabBrowser.tabContainer; - tabBrowser.removeTabsProgressListener(tabWatcher); } tabContainer.removeEventListener('TabClose', tabWatcher.onTabClose); @@ -1348,7 +1346,7 @@ vAPI.net.registerListeners = function() { tabId: tabId, url: details.url, }); - } + }; vAPI.messaging.globalMessageManager.addMessageListener( locationChangedListenerMessageName,