1
0
mirror of https://github.com/gorhill/uBlock.git synced 2024-09-14 23:12:28 +02:00

code review

This commit is contained in:
gorhill 2015-08-02 23:49:17 -04:00
parent 8e5ff6693b
commit 6ea3338f26
2 changed files with 11 additions and 9 deletions

View File

@ -470,13 +470,14 @@ var uBlockCollapser = (function() {
if ( shadow !== null && shadow.className === sessionId ) { if ( shadow !== null && shadow.className === sessionId ) {
continue; continue;
} }
// https://github.com/w3c/webcomponents/issues/102
// not all nodes can be shadowed // not all nodes can be shadowed
try { try {
shadow = elem.createShadowRoot(); shadow = elem.createShadowRoot();
} catch (ex) {
continue;
}
shadow.className = sessionId; shadow.className = sessionId;
} catch (ex) {
elem.style.setProperty('display', 'none', 'important');
}
} }
}; };

View File

@ -181,13 +181,14 @@ var hideElements = function(selectors) {
if ( shadow !== null && shadow.className === sessionId ) { if ( shadow !== null && shadow.className === sessionId ) {
continue; continue;
} }
// https://github.com/w3c/webcomponents/issues/102
// not all nodes can be shadowed // not all nodes can be shadowed
try { try {
shadow = elem.createShadowRoot(); shadow = elem.createShadowRoot();
} catch (ex) {
continue;
}
shadow.className = sessionId; shadow.className = sessionId;
} catch (ex) {
elem.style.setProperty('display', 'none', 'important');
}
} }
}; };