1
0
mirror of https://github.com/gorhill/uBlock.git synced 2024-09-01 16:49:39 +02:00

code review

This commit is contained in:
gorhill 2015-08-02 23:49:17 -04:00
parent 8e5ff6693b
commit 6ea3338f26
2 changed files with 11 additions and 9 deletions

View File

@ -470,13 +470,14 @@ var uBlockCollapser = (function() {
if ( shadow !== null && shadow.className === sessionId ) { if ( shadow !== null && shadow.className === sessionId ) {
continue; continue;
} }
// https://github.com/w3c/webcomponents/issues/102
// not all nodes can be shadowed // not all nodes can be shadowed
try { try {
shadow = elem.createShadowRoot(); shadow = elem.createShadowRoot();
shadow.className = sessionId;
} catch (ex) { } catch (ex) {
continue; elem.style.setProperty('display', 'none', 'important');
} }
shadow.className = sessionId;
} }
}; };

View File

@ -181,13 +181,14 @@ var hideElements = function(selectors) {
if ( shadow !== null && shadow.className === sessionId ) { if ( shadow !== null && shadow.className === sessionId ) {
continue; continue;
} }
// not all nodes can be shadowed // https://github.com/w3c/webcomponents/issues/102
try { // not all nodes can be shadowed
shadow = elem.createShadowRoot(); try {
} catch (ex) { shadow = elem.createShadowRoot();
continue; shadow.className = sessionId;
} } catch (ex) {
shadow.className = sessionId; elem.style.setProperty('display', 'none', 'important');
}
} }
}; };