From 788ff0a21f8b6ab20825c6a81d46a0efa3ce4881 Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 26 Jul 2016 08:21:03 -0400 Subject: [PATCH] code review: do not delay injection of specific cosmetic filters --- src/js/contentscript.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/js/contentscript.js b/src/js/contentscript.js index f152625bd..6be19d9a8 100644 --- a/src/js/contentscript.js +++ b/src/js/contentscript.js @@ -346,15 +346,18 @@ var domFilterer = { } }, - commit: function(nodes) { - if ( stagedNodes.length === 0 ) { - window.requestAnimationFrame(this.commit_.bind(this)); - } + commit: function(nodes, commitNow) { + var firstCommit = stagedNodes.length === 0; if ( nodes === undefined ) { stagedNodes = [ document.documentElement ]; } else if ( stagedNodes[0] !== document.documentElement ) { stagedNodes = stagedNodes.concat(nodes); } + if ( commitNow ) { + this.commit_(); + } else if ( firstCommit ) { + window.requestAnimationFrame(this.commit_.bind(this)); + } }, hideNode: function(node) { @@ -562,7 +565,7 @@ return domFilterer; domFilterer.addExceptions(details.cosmeticDonthide); // https://github.com/chrisaljoudi/uBlock/issues/143 domFilterer.addSelectors(details.cosmeticHide); - domFilterer.commit(); + domFilterer.commit(undefined, true); }; var netFilters = function(details) {