From 8616b395b221a3bb853e545c9aad3e72e1ab1d83 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Fri, 21 Apr 2023 19:24:43 -0400 Subject: [PATCH] Internally support no-filtering as default mode Even though this cannot be set through the user interface. --- platform/mv3/extension/js/mode-manager.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/platform/mv3/extension/js/mode-manager.js b/platform/mv3/extension/js/mode-manager.js index 1b52f6cb9..8ac0ccfd2 100644 --- a/platform/mv3/extension/js/mode-manager.js +++ b/platform/mv3/extension/js/mode-manager.js @@ -131,13 +131,17 @@ async function setFilteringModeDetails(afterDetails) { id: TRUSTED_DIRECTIVE_BASE_RULE_ID, action: { type: 'allowAllRequests' }, condition: { - requestDomains: [], resourceTypes: [ 'main_frame' ], }, priority: 100, }; - if ( actualDetails.none.size ) { - rule.condition.requestDomains = Array.from(actualDetails.none); + if ( actualDetails.none.size !== 0 ) { + if ( + actualDetails.none.size !== 1 || + actualDetails.none.has('all-urls') === false + ) { + rule.condition.requestDomains = Array.from(actualDetails.none); + } addRules.push(rule); dynamicRuleMap.set(TRUSTED_DIRECTIVE_BASE_RULE_ID, rule); }