From 89fd76ac39619081ade482e98aa6cd1a0ce13f7a Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Mon, 7 May 2018 19:03:50 -0400 Subject: [PATCH] use image data instead of paths for browser icons When using paths, platform implementations of setIcon typically will fetch the resource then convert to image data internally. It is preferable for uBO to do this conversion itself as it can be done only once at launch time. With chromium-based browsers, using image data eliminate the incessant network traffic to fetch browser icons as reported in the extension's dev tool, meaning a good chunk of overhead is eliminated. Also, use optimal icon sizes, as of now both chromium and firefox prefers 16px instead of 19px, and 32px instead of 38px. --- .../chromium/img/browsericons/icon19-off.png | Bin 954 -> 0 bytes platform/chromium/img/browsericons/icon19.png | Bin 995 -> 0 bytes .../chromium/img/browsericons/icon38-off.png | Bin 1726 -> 0 bytes platform/chromium/img/browsericons/icon38.png | Bin 1841 -> 0 bytes platform/chromium/manifest.json | 4 +- platform/chromium/vapi-background.js | 56 ++++++++++++++---- platform/firefox/manifest.json | 4 +- platform/opera/manifest.json | 8 +-- platform/webext/manifest.json | 4 +- tools/make-chromium.sh | 1 - tools/make-firefox.sh | 1 - tools/make-opera.sh | 1 - tools/make-webext.sh | 1 - 13 files changed, 56 insertions(+), 24 deletions(-) delete mode 100644 platform/chromium/img/browsericons/icon19-off.png delete mode 100644 platform/chromium/img/browsericons/icon19.png delete mode 100644 platform/chromium/img/browsericons/icon38-off.png delete mode 100644 platform/chromium/img/browsericons/icon38.png diff --git a/platform/chromium/img/browsericons/icon19-off.png b/platform/chromium/img/browsericons/icon19-off.png deleted file mode 100644 index 79fb3b823faa18dbaf2b264651ecaf32d9f872cc..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 954 zcmV;r14aCaP)-8BDqt~2zdhrOi2qlmqLy-Zt7YQS`dOl zi4-aUx2r=PI(A40n?Jxp9Xg4F#i4_PLDaFB8&tyeHgAY{$!Xq-&6#xR9jD&)$FsaV z@AG^=@ArLpd6~({Nd(2p%F4r&latq$Wjzx`@rxu$AC{Juz6bR)ez0=6oH{-}Rt&>< z(Q35@o&CPPzUJ`o@aNId(Xyf_x-V>DVd3M&#l<54gWYadq?8g$DIerO5QHCsAk-O# zu>dp&1_rd%)zw!V0GOuv zwx@vJ-d?vc6bgakH~?_hyW!}$-$~mkjEsz6c6Jt}QV9SsGc$uurvp(GK?s4Ws@U7x zL!;5~!rESEf!7R&!;mBinx_4T#)%%U1VNfP$=_ff4@Z;c`zj~}|QbUIy8RrTuf@-hMdwOS3eTJ4r#YirAQrv3f> zSLt-R;?As4C^QHm+rHg@2|~zrp-^bJFaXHqa`TBq;^2QkiA3Tcm&?sNxeF^6i_L5{ znmm))LZlY z&j4U~dHJcX>+kCIy6kcDEtN{WEtN`N{WO6v09apN5AW{ozBxNPdl`$xK8=r$zt89M cKZE*z0ZZKN!SC2YssI2007*qoM6N<$f?W@!EC2ui diff --git a/platform/chromium/img/browsericons/icon19.png b/platform/chromium/img/browsericons/icon19.png deleted file mode 100644 index e6d57bdda9a31de7e0b1663691bfa6e4831c49a4..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 995 zcmV<9104K`P)CylGzOO%@tMMOH{+5h79-(uE)4lqlh(sOa1QxB0P+xy^Nv=Q!m| z^tpS_|Ns2n=l{MhhtO)Zh^5zh{jEP^V~=;&*DDj!)5o$ZD=klkhyTXvC%9nU27~hV z=xFQK>}=hE)0xP8kC(|jH;ao0vvs=eR;zV|6V@aazuVi`$V4QP7y%NzPN&pM)1p`j z#8RnGER)d$unU6lTu)1*-g>WEXWknOH0wZw#GKz8ybRc za1c#1GkCVMgS&lwNKz`#!h$ETbH=<9ACGLE4%Ea1KGxJAB_{`WdV5d9j{W@TnYomh zkpcJWD!#R~0RUVSg_flyBxh#AMNx?MlgAzpV-EU!AO!+|AOHZ7qa*gr06-*>Abfa; zz}{Z;o*p)tNFrGTPz3;6^YaM#{kYxUjsu4S;*=B!L?YCTk7H|Y4h4;k_+_)fOViOC zEFuv2pG>A!FEE8jIE+sX4Y-k?k6gVT-#a?+rmzqP4hOQTsxaNvg)c2Fr;dX06I!hn z*3QnP57pJ1`sk0Hk;gFHoHjxFqqA5sY*3@Sr7n7RjNsY+3W^RE&v*n zsa~$p{J0EAuF?F^m`wG|nuRr6ES@5xv0AE9*)N#LUSu>@H(M<1OW-LK3btXwZr^`U zTl+ca^Cf$o&fKF=h&&773x(mdk`ilPU0u`Dk&(^l8t4BE0G_MW6)RIyujr+v0ya%< z?oVZT`HQZFg|A$mQ^}$=y}eDn92j`-ce#QDkEh5eE91lY>-@hDd^nZjc_pY@| RvpN6(002ovPDHLkV1jZ&xE%lh diff --git a/platform/chromium/img/browsericons/icon38-off.png b/platform/chromium/img/browsericons/icon38-off.png deleted file mode 100644 index a1b5c00bf32b759fa2b5505e4b569ea1bb3b08c8..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1726 zcmV;v20{6WP)U|WLpzT zO*fZzA2hR*W}<0h>;7S2<~!&6&Tqasw>iYVefvUf!4=Oy~@hUg2#^^zYGA1tmD(CPd~eJ=g!9~YPATZ zQYk!q_;53T&4ub%ES5h2Tm}GH)<_UUX0@P-m6$;$vVU+eh!_MgnM{`cFf9K`%<%uu z7(oypJY!;pqQJ_^%0SaJ)~{cmSEf`dLDMv7n$EGS)#{SK6e8n7A%{JC_Mok;4e@v! zJv}`+W!tuGLwkEW0KnyPVgLU9Fc=J=C<@7B5|Ky*BO@bt_Uu_PU;=}%GMNmoUcG|H<3ThUg+`-6b8|Cjn#S(k zyD>F21+Ujz&|l0T1}nMq$K!GI_xEFNZceayJRTf9dK7xS9yXf|JkKMUOcnym@BAyB z$I8pgh5MT~Z{|P&Kr)%c@bEAIK&4Vaub146(;GG1O9O8|gEp}@wC8*|DwZQ3N<@7=o> zEX(GUn@lFyY&HQZ8jVV}L6RgYD=R0n&%&tG>-Bdv8cp)Wix8^lPgwv;8FCF&U0pp_S64S6w&j31olYOaFrKx= z0vLwzIGs+P*d|+AslLActWKwktre6`r;F9s*PmT#&jai1?7VHUSo#aiY41}cNy1{W z^mlf4-hL+-0I)23%4)UV%FfoSA%Y-awOVhnEPG0-ToR1qxJ+wntHWlq4XsAzNRouj zW*cg4ZFO)QC;1a33HAmq(bCd#$Zog0)M|CfyW6bPYIVwPx4T+eS`Kj>S8zoy>QLqU z`Sab69zFVUe0zbULWTfhB*|NoNHkw2xMlz7lyuZNI5=3t^ZfVs@8AC< z9*OV07*qoM6N<$g4QV?KL7v# diff --git a/platform/chromium/img/browsericons/icon38.png b/platform/chromium/img/browsericons/icon38.png deleted file mode 100644 index 09a57d2ffb6e32604912d9aa260487a9e0cc204b..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1841 zcmV-12hRA3P)CBp zmo%4@9Qi#zKVq=E+X4Wrot$0dgMl%k*E94lUI=x4eNG0g)=Agj@6=LS z>SEAp&AO3^;s^xr3=i+%+1PY*1cGj!t!+2g%1XoHaz|Ml&M1q^9kmn+JHO1%J_7*k zvA}*&7#*Dv7&T+B=mJ)zq##+XhPz*M+DI)EYCZBTuDWH8t>9w+=j8TL1vp+8VAQA=rN7 z2G-~1nnCu4f%+(EGiI)sY&M3TKS%BH<9OE81Y37^1SBLtC>CQyQWBmvG@!n)ke-Xe zU{;NptAX}*@W^F7)Yj*%ox|&y4_A9d1fkTxW6BzNl7pc4})!KiA5_{Lb7QS3Ds3ogHyr5 z!P8wVDnP_(#8rM2%D3viW6Yhx6O7OIUo(P?pL=wSzc zf6e=Xa`5-pEDjAlJkdT0EJ3L(Tdq*#)Ah7>DGr~HK%bRxkkYlgkfCGc#{7 zSgbjNVz5|{W@g^vM8W1|=s)69l27^E2zC%6D;biGN+Xl+s*M z;yD{Auc)Y&rP0yZ$%Ta{-sZ~^Q_fR#`nA6P-ZupWMS_J37YuZEdg^+6Ev5rxCy@-U zPD?u7^6Bhj zR>r8ha_3Il5tZskYmrE&*J?dAYPHampWE8C?ZIhjN2M7V@tfo0)uw!=(yTsps`By{ zHL6rc8&048bfBYy2LSV3Ty(xWcmC`h6O$gJP;|X*jX41u(}_KMA|777dJq7XY}|Mx fF*o