From 8e4f998a329998e3ce0d9b38e3abe72402092531 Mon Sep 17 00:00:00 2001 From: gorhill Date: Thu, 6 Aug 2015 14:43:35 -0400 Subject: [PATCH] this fixes #574 --- platform/firefox/vapi-background.js | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/platform/firefox/vapi-background.js b/platform/firefox/vapi-background.js index 16d796b8a..a3cc5b050 100644 --- a/platform/firefox/vapi-background.js +++ b/platform/firefox/vapi-background.js @@ -1039,7 +1039,7 @@ var tabWatcher = (function() { return; } - var tabContainer = null; + var tabContainer; if ( tabBrowser.deck ) { // Fennec tabContainer = tabBrowser.deck; } else if ( tabBrowser.tabContainer ) { // Firefox @@ -1052,8 +1052,20 @@ var tabWatcher = (function() { tabContainer.removeEventListener('TabSelect', onSelect); } + // https://github.com/gorhill/uBlock/issues/574 + // To keep in mind: not all windows are tab containers, + // sometimes the window IS the tab. + var tabs; + if ( tabBrowser.tabs ) { + tabs = tabBrowser.tabs; + } else if ( tabBrowser.localName === 'browser' ) { + tabs = [tabBrowser]; + } else { + tabs = []; + } + var browser, URI, tabId; - for ( var tab of tabBrowser.tabs ) { + for ( var tab of tabs ) { browser = tabWatcher.browserFromTarget(tab); if ( browser === null ) { continue;