From a927725bd9389389f1a4f0f71b6c47941878d48e Mon Sep 17 00:00:00 2001 From: gorhill Date: Sat, 7 Jan 2017 17:18:22 -0500 Subject: [PATCH] code review: one getter per instance is wasteful --- src/js/static-net-filtering.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/js/static-net-filtering.js b/src/js/static-net-filtering.js index f389281bf..9f092072b 100644 --- a/src/js/static-net-filtering.js +++ b/src/js/static-net-filtering.js @@ -1066,14 +1066,14 @@ var FilterBucket = function(a, b) { this.filters[1] = b; } } - - Object.defineProperty(this, 'rtfid', { - get: function() { - return this.f.rtfid; - } - }); }; +Object.defineProperty(FilterBucket.prototype, 'rtfid', { + get: function() { + return this.f.rtfid; + } +}); + FilterBucket.prototype.add = function(a) { this.filters.push(a); };