From c49ba60f0bb0f309a44bd970d51b9861965c78f3 Mon Sep 17 00:00:00 2001
From: gorhill <rhill@raymondhill.net>
Date: Thu, 5 Oct 2017 08:38:34 -0400
Subject: [PATCH] minor code review

---
 src/js/cosmetic-filtering.js | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/src/js/cosmetic-filtering.js b/src/js/cosmetic-filtering.js
index 2fad82b1d..8c0fd35e1 100644
--- a/src/js/cosmetic-filtering.js
+++ b/src/js/cosmetic-filtering.js
@@ -948,25 +948,19 @@ FilterContainer.prototype.compileProceduralSelector = (function() {
                     break;
                 case ':has-text':
                     value = regexToRawValue.get(task[1]);
-                    raw.push(
-                        task[0],
-                        '(',
-                        value !== undefined ? value : '/' + task[1] + '/',
-                        ')'
-                    );
+                    if ( value === undefined ) {
+                        value = '/' + task[1] + '/';
+                    }
+                    raw.push(task[0], '(', value, ')');
                     break;
                 case ':matches-css':
                 case ':matches-css-after':
                 case ':matches-css-before':
                     value = regexToRawValue.get(task[1].value);
-                    raw.push(
-                        task[0],
-                        '(',
-                        task[1].name,
-                        ': ',
-                        value !== undefined ? value : '/' + task[1].value + '/',
-                        ')'
-                    );
+                    if ( value === undefined ) {
+                        value = '/' + task[1].value + '/';
+                    }
+                    raw.push(task[0], '(', task[1].name, ': ', value, ')');
                     break;
                 case ':if':
                 case ':if-not':
@@ -1033,6 +1027,9 @@ FilterContainer.prototype.compileProceduralSelector = (function() {
         var compiled = compile(raw);
         if ( compiled !== undefined ) {
             compiled.raw = decompile(compiled);
+            if ( compiled.raw !== raw ) {
+                console.log(raw, '\n', compiled.raw, '\n');
+            }
             compiled = JSON.stringify(compiled);
         }
         lastProceduralSelectorCompiled = compiled;