1
0
mirror of https://github.com/gorhill/uBlock.git synced 2024-09-04 01:59:38 +02:00

code review: adjust position of eraser/padlock only when needed

This commit is contained in:
Raymond Hill 2018-04-04 08:17:53 -04:00
parent 18459161e6
commit c695599860
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2

View File

@ -61,12 +61,11 @@ if (
// The padlock/eraser must be manually positioned:
// - Its vertical position depends on the height of the popup title bar
// - Its horizontal position depends on whether there is a vertical scrollbar.
document.getElementById('rulesetTools').style.setProperty(
'top',
(document.getElementById('appinfo').getBoundingClientRect().bottom + 3) + 'px'
);
var positionRulesetTools = function() {
document.getElementById('rulesetTools').style.setProperty(
'top',
(document.getElementById('appinfo').getBoundingClientRect().bottom + 3) + 'px'
);
document.getElementById('rulesetTools').style.setProperty(
'left',
(document.getElementById('firewallContainer').getBoundingClientRect().left + 3) + 'px'
@ -317,12 +316,11 @@ var updateAllFirewallCells = function() {
);
}
positionRulesetTools();
uDom.nodeFromId('firewallContainer').classList.toggle(
'dirty',
popupData.matrixIsDirty === true
);
var dirty = popupData.matrixIsDirty === true;
if ( dirty ) {
positionRulesetTools();
}
uDom.nodeFromId('firewallContainer').classList.toggle('dirty', dirty);
};
/******************************************************************************/