Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-09-15 15:32:28 +02:00
Code Issues Releases Wiki Activity

code review: adjust position of eraser/padlock only when needed

Browse Source
This commit is contained in:
Raymond Hill 2018-04-04 08:17:53 -04:00
parent 18459161e6
commit c695599860
No known key found for this signature in database
GPG Key ID: 25E1490B761470C2
1 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/js/popup.js
View File

@ -61,12 +61,11 @@ if (
// The padlock/eraser must be manually positioned: // The padlock/eraser must be manually positioned:
// - Its vertical position depends on the height of the popup title bar // - Its vertical position depends on the height of the popup title bar
// - Its horizontal position depends on whether there is a vertical scrollbar. // - Its horizontal position depends on whether there is a vertical scrollbar.
document.getElementById('rulesetTools').style.setProperty(
'top',
(document.getElementById('appinfo').getBoundingClientRect().bottom + 3) + 'px'
);
var positionRulesetTools = function() { var positionRulesetTools = function() {
document.getElementById('rulesetTools').style.setProperty(
'top',
(document.getElementById('appinfo').getBoundingClientRect().bottom + 3) + 'px'
);
document.getElementById('rulesetTools').style.setProperty( document.getElementById('rulesetTools').style.setProperty(
'left', 'left',
(document.getElementById('firewallContainer').getBoundingClientRect().left + 3) + 'px' (document.getElementById('firewallContainer').getBoundingClientRect().left + 3) + 'px'
@ -317,12 +316,11 @@ var updateAllFirewallCells = function() {
); );
} }
positionRulesetTools(); var dirty = popupData.matrixIsDirty === true;
if ( dirty ) {
uDom.nodeFromId('firewallContainer').classList.toggle( positionRulesetTools();
'dirty', }
popupData.matrixIsDirty === true uDom.nodeFromId('firewallContainer').classList.toggle('dirty', dirty);
);
}; };
/******************************************************************************/ /******************************************************************************/