From cb69ff934540be6e5c6ab1cb4169adac618bac60 Mon Sep 17 00:00:00 2001 From: gorhill Date: Thu, 19 Mar 2015 13:13:25 -0400 Subject: [PATCH] this fixes #1048 --- src/js/contentscript-end.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/js/contentscript-end.js b/src/js/contentscript-end.js index 01a98808b..78a496a94 100644 --- a/src/js/contentscript-end.js +++ b/src/js/contentscript-end.js @@ -682,13 +682,19 @@ var messager = vAPI.messaging.channel('contentscript-end.js'); var requests = details.requests; var selectors = []; var i = requests.length; - var request; + var request, elem, attr, value; while ( i-- ) { request = requests[i]; + elem = elements[request.index]; // https://github.com/gorhill/uBlock/issues/399 // Never remove elements from the DOM, just hide them - elements[request.index].style.setProperty('display', 'none', 'important'); - selectors.push(request.tagName + '[' + srcProps[request.tagName] + '="' + request.url + '"]'); + elem.style.setProperty('display', 'none', 'important'); + // https://github.com/gorhill/uBlock/issues/1048 + // Use attribute to construct CSS rule + attr = srcProps[request.tagName]; + if ( value = elem.getAttribute(attr) ) { + selectors.push(request.tagName + '[' + attr + '="' + value + '"]'); + } } if ( selectors.length !== 0 ) { messager.send({