Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-07-05 11:37:01 +02:00
Code Issues Releases Wiki Activity

this tentatively fixes #1514

Browse Source
This commit is contained in:
gorhill 2016-03-29 11:37:19 -04:00
parent 62b087ef88
commit cf47bdc4c8
1 changed files with 13 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
platform/firefox/frameScript.js
View File

@ -24,44 +24,30 @@
// https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Frame_script_environment
(function() {
'use strict';
if ( !this.docShell ) {
return;
}
let {LocationChangeListener} = Components.utils.import(
Components.stack.filename.replace('Script', 'Module'),
null
);
// https://github.com/gorhill/uBlock/issues/1444
// Apparently the same context is used for all extensions, hence we must
// use scoped variables to ensure no collision.
let locationChangeListener;
// Apparently, on older versions of Firefox (31 and less), the same context
// is used for all extensions, hence we must use a unique variable name to
// ensure no collision.
this.ublock0LocationChangeListener = null;
// https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Progress_Listeners
// "Note that the browser uses a weak reference to your listener object,
// "so make sure to keep an external reference to your object to ensure
// "that it stays in memory."
// This listener below allows us to keep `locationChangeListener` alive
// until we no longer need it.
let shutdown = function(ev) {
if ( ev.target === this ) {
this.removeEventListener('unload', shutdown);
locationChangeListener = null;
// https://github.com/gorhill/uBlock/issues/1514
// Fix?
if ( this.docShell ) {
let webProgress = this.docShell
.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
.getInterface(Components.interfaces.nsIWebProgress);
let domWindow = webProgress.DOMWindow;
if ( domWindow === domWindow.top ) {
this.ublock0LocationChangeListener = new LocationChangeListener(this.docShell, webProgress);
}
};
this.addEventListener('unload', shutdown);
let webProgress = this.docShell
.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
.getInterface(Components.interfaces.nsIWebProgress);
if ( webProgress && webProgress.isTopLevel ) {
locationChangeListener = new LocationChangeListener(this.docShell, webProgress);
}
}).call(this);
/******************************************************************************/