Mirrors/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2024-07-08 04:49:12 +02:00
Code Issues Releases Wiki Activity

this tentatively fixes #1514

Browse Source
This commit is contained in:
gorhill 2016-03-29 11:37:19 -04:00
parent 62b087ef88
commit cf47bdc4c8
1 changed files with 13 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
platform/firefox/frameScript.js
View File

@ -24,44 +24,30 @@
// https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Frame_script_environment // https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Frame_script_environment
(function() { (function() {
'use strict'; 'use strict';
if ( !this.docShell ) {
return;
}
let {LocationChangeListener} = Components.utils.import( let {LocationChangeListener} = Components.utils.import(
Components.stack.filename.replace('Script', 'Module'), Components.stack.filename.replace('Script', 'Module'),
null null
); );
// https://github.com/gorhill/uBlock/issues/1444 // https://github.com/gorhill/uBlock/issues/1444
// Apparently the same context is used for all extensions, hence we must // Apparently, on older versions of Firefox (31 and less), the same context
// use scoped variables to ensure no collision. // is used for all extensions, hence we must use a unique variable name to
let locationChangeListener; // ensure no collision.
this.ublock0LocationChangeListener = null;
// https://developer.mozilla.org/en-US/Add-ons/Code_snippets/Progress_Listeners // https://github.com/gorhill/uBlock/issues/1514
// "Note that the browser uses a weak reference to your listener object, // Fix?
// "so make sure to keep an external reference to your object to ensure if ( this.docShell ) {
// "that it stays in memory." let webProgress = this.docShell
// This listener below allows us to keep `locationChangeListener` alive .QueryInterface(Components.interfaces.nsIInterfaceRequestor)
// until we no longer need it. .getInterface(Components.interfaces.nsIWebProgress);
let shutdown = function(ev) { let domWindow = webProgress.DOMWindow;
if ( ev.target === this ) { if ( domWindow === domWindow.top ) {
this.removeEventListener('unload', shutdown); this.ublock0LocationChangeListener = new LocationChangeListener(this.docShell, webProgress);
locationChangeListener = null;
} }
};
this.addEventListener('unload', shutdown);
let webProgress = this.docShell
.QueryInterface(Components.interfaces.nsIInterfaceRequestor)
.getInterface(Components.interfaces.nsIWebProgress);
if ( webProgress && webProgress.isTopLevel ) {
locationChangeListener = new LocationChangeListener(this.docShell, webProgress);
} }
}).call(this); }).call(this);
/******************************************************************************/ /******************************************************************************/